Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: src/x87/full-codegen-x87.cc

Issue 713813002: Revert "Fix stepping in for-loops." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1016 matching lines...) Expand 10 before | Expand all | Expand 10 after
1027 FeedbackVectorSlot slot = stmt->ForInFeedbackSlot(); 1027 FeedbackVectorSlot slot = stmt->ForInFeedbackSlot();
1028 1028
1029 SetStatementPosition(stmt); 1029 SetStatementPosition(stmt);
1030 1030
1031 Label loop, exit; 1031 Label loop, exit;
1032 ForIn loop_statement(this, stmt); 1032 ForIn loop_statement(this, stmt);
1033 increment_loop_depth(); 1033 increment_loop_depth();
1034 1034
1035 // Get the object to enumerate over. If the object is null or undefined, skip 1035 // Get the object to enumerate over. If the object is null or undefined, skip
1036 // over the loop. See ECMA-262 version 5, section 12.6.4. 1036 // over the loop. See ECMA-262 version 5, section 12.6.4.
1037 SetExpressionPosition(stmt->enumerable());
1038 VisitForAccumulatorValue(stmt->enumerable()); 1037 VisitForAccumulatorValue(stmt->enumerable());
1039 __ cmp(eax, isolate()->factory()->undefined_value()); 1038 __ cmp(eax, isolate()->factory()->undefined_value());
1040 __ j(equal, &exit); 1039 __ j(equal, &exit);
1041 __ cmp(eax, isolate()->factory()->null_value()); 1040 __ cmp(eax, isolate()->factory()->null_value());
1042 __ j(equal, &exit); 1041 __ j(equal, &exit);
1043 1042
1044 PrepareForBailoutForId(stmt->PrepareId(), TOS_REG); 1043 PrepareForBailoutForId(stmt->PrepareId(), TOS_REG);
1045 1044
1046 // Convert the object to a JS object. 1045 // Convert the object to a JS object.
1047 Label convert, done_convert; 1046 Label convert, done_convert;
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 __ test(eax, eax); 1162 __ test(eax, eax);
1164 __ j(equal, loop_statement.continue_label()); 1163 __ j(equal, loop_statement.continue_label());
1165 __ mov(ebx, eax); 1164 __ mov(ebx, eax);
1166 1165
1167 // Update the 'each' property or variable from the possibly filtered 1166 // Update the 'each' property or variable from the possibly filtered
1168 // entry in register ebx. 1167 // entry in register ebx.
1169 __ bind(&update_each); 1168 __ bind(&update_each);
1170 __ mov(result_register(), ebx); 1169 __ mov(result_register(), ebx);
1171 // Perform the assignment as if via '='. 1170 // Perform the assignment as if via '='.
1172 { EffectContext context(this); 1171 { EffectContext context(this);
1173 SetExpressionPosition(stmt->each());
1174 EmitAssignment(stmt->each()); 1172 EmitAssignment(stmt->each());
1175 } 1173 }
1176 1174
1177 // Generate code for the body of the loop. 1175 // Generate code for the body of the loop.
1178 Visit(stmt->body()); 1176 Visit(stmt->body());
1179 1177
1180 // Generate code for going to the next element by incrementing the 1178 // Generate code for going to the next element by incrementing the
1181 // index (smi) stored on top of the stack. 1179 // index (smi) stored on top of the stack.
1182 __ bind(loop_statement.continue_label()); 1180 __ bind(loop_statement.continue_label());
1183 __ add(Operand(esp, 0 * kPointerSize), Immediate(Smi::FromInt(1))); 1181 __ add(Operand(esp, 0 * kPointerSize), Immediate(Smi::FromInt(1)));
1184 1182
1185 EmitBackEdgeBookkeeping(stmt, &loop); 1183 EmitBackEdgeBookkeeping(stmt, &loop);
1186 __ jmp(&loop); 1184 __ jmp(&loop);
1187 1185
1188 // Remove the pointers stored on the stack. 1186 // Remove the pointers stored on the stack.
1189 __ bind(loop_statement.break_label()); 1187 __ bind(loop_statement.break_label());
1190 __ add(esp, Immediate(5 * kPointerSize)); 1188 __ add(esp, Immediate(5 * kPointerSize));
1191 1189
1192 // Exit and decrement the loop depth. 1190 // Exit and decrement the loop depth.
1193 PrepareForBailoutForId(stmt->ExitId(), NO_REGISTERS); 1191 PrepareForBailoutForId(stmt->ExitId(), NO_REGISTERS);
1194 __ bind(&exit); 1192 __ bind(&exit);
1195 decrement_loop_depth(); 1193 decrement_loop_depth();
1196 } 1194 }
1197 1195
1198 1196
1197 void FullCodeGenerator::VisitForOfStatement(ForOfStatement* stmt) {
1198 Comment cmnt(masm_, "[ ForOfStatement");
1199 SetStatementPosition(stmt);
1200
1201 Iteration loop_statement(this, stmt);
1202 increment_loop_depth();
1203
1204 // var iterator = iterable[Symbol.iterator]();
1205 VisitForEffect(stmt->assign_iterator());
1206
1207 // Loop entry.
1208 __ bind(loop_statement.continue_label());
1209
1210 // result = iterator.next()
1211 VisitForEffect(stmt->next_result());
1212
1213 // if (result.done) break;
1214 Label result_not_done;
1215 VisitForControl(stmt->result_done(),
1216 loop_statement.break_label(),
1217 &result_not_done,
1218 &result_not_done);
1219 __ bind(&result_not_done);
1220
1221 // each = result.value
1222 VisitForEffect(stmt->assign_each());
1223
1224 // Generate code for the body of the loop.
1225 Visit(stmt->body());
1226
1227 // Check stack before looping.
1228 PrepareForBailoutForId(stmt->BackEdgeId(), NO_REGISTERS);
1229 EmitBackEdgeBookkeeping(stmt, loop_statement.continue_label());
1230 __ jmp(loop_statement.continue_label());
1231
1232 // Exit and decrement the loop depth.
1233 PrepareForBailoutForId(stmt->ExitId(), NO_REGISTERS);
1234 __ bind(loop_statement.break_label());
1235 decrement_loop_depth();
1236 }
1237
1238
1199 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info, 1239 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info,
1200 bool pretenure) { 1240 bool pretenure) {
1201 // Use the fast case closure allocation code that allocates in new 1241 // Use the fast case closure allocation code that allocates in new
1202 // space for nested functions that don't need literals cloning. If 1242 // space for nested functions that don't need literals cloning. If
1203 // we're running with the --always-opt or the --prepare-always-opt 1243 // we're running with the --always-opt or the --prepare-always-opt
1204 // flag, we need to use the runtime function so that the new function 1244 // flag, we need to use the runtime function so that the new function
1205 // we are creating here gets a chance to have its code optimized and 1245 // we are creating here gets a chance to have its code optimized and
1206 // doesn't just get a copy of the existing unoptimized code. 1246 // doesn't just get a copy of the existing unoptimized code.
1207 if (!FLAG_always_opt && 1247 if (!FLAG_always_opt &&
1208 !FLAG_prepare_always_opt && 1248 !FLAG_prepare_always_opt &&
(...skipping 3955 matching lines...) Expand 10 before | Expand all | Expand 10 after
5164 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5204 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5165 Assembler::target_address_at(call_target_address, 5205 Assembler::target_address_at(call_target_address,
5166 unoptimized_code)); 5206 unoptimized_code));
5167 return OSR_AFTER_STACK_CHECK; 5207 return OSR_AFTER_STACK_CHECK;
5168 } 5208 }
5169 5209
5170 5210
5171 } } // namespace v8::internal 5211 } } // namespace v8::internal
5172 5212
5173 #endif // V8_TARGET_ARCH_X87 5213 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698