Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 713803002: [turbofan] add register assignment verifier (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] add register assignment verifier R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=25242

Patch Set 1 : #

Patch Set 2 : better handling of sameasfirst #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -5 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction.h View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/register-allocator.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/register-allocator.cc View 3 chunks +14 lines, -1 line 0 comments Download
A src/compiler/register-allocator-verifier.h View 1 2 3 1 chunk +68 lines, -0 lines 0 comments Download
A src/compiler/register-allocator-verifier.cc View 1 2 1 chunk +179 lines, -0 lines 2 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dcarney
ptal
6 years, 1 month ago (2014-11-10 10:08:02 UTC) #4
Jarin
lgtm. https://codereview.chromium.org/713803002/diff/100001/src/compiler/register-allocator-verifier.cc File src/compiler/register-allocator-verifier.cc (right): https://codereview.chromium.org/713803002/diff/100001/src/compiler/register-allocator-verifier.cc#newcode103 src/compiler/register-allocator-verifier.cc:103: CHECK(false); What is wrong with the ANY constraint?
6 years, 1 month ago (2014-11-10 11:24:59 UTC) #5
dcarney
https://codereview.chromium.org/713803002/diff/100001/src/compiler/register-allocator-verifier.cc File src/compiler/register-allocator-verifier.cc (right): https://codereview.chromium.org/713803002/diff/100001/src/compiler/register-allocator-verifier.cc#newcode103 src/compiler/register-allocator-verifier.cc:103: CHECK(false); On 2014/11/10 11:24:59, jarin wrote: > What is ...
6 years, 1 month ago (2014-11-10 11:27:17 UTC) #6
dcarney
6 years, 1 month ago (2014-11-10 11:29:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:100001) manually as 25242 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698