Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: Source/bindings/core/v8/ScriptController.cpp

Issue 713743002: Remove a EscapableHandleScope from executeScriptInIsolatedWorld() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptController.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptController.cpp
diff --git a/Source/bindings/core/v8/ScriptController.cpp b/Source/bindings/core/v8/ScriptController.cpp
index e614f21246a795cf9c306860a34d640318ef8bb6..913ff04982b62d86c78b4319304ae2feb7a602ab 100644
--- a/Source/bindings/core/v8/ScriptController.cpp
+++ b/Source/bindings/core/v8/ScriptController.cpp
@@ -637,8 +637,7 @@ void ScriptController::executeScriptInIsolatedWorld(int worldID, const Vector<Sc
return;
ScriptState* scriptState = isolatedWorldWindowProxy->scriptState();
- v8::EscapableHandleScope handleScope(scriptState->isolate());
- ScriptState::Scope scope(scriptState);
+ v8::Context::Scope scope(scriptState->context());
v8::Local<v8::Array> resultArray = v8::Array::New(m_isolate, sources.size());
for (size_t i = 0; i < sources.size(); ++i) {
@@ -650,7 +649,7 @@ void ScriptController::executeScriptInIsolatedWorld(int worldID, const Vector<Sc
if (results) {
for (size_t i = 0; i < resultArray->Length(); ++i)
- results->append(handleScope.Escape(resultArray->Get(i)));
+ results->append(resultArray->Get(i));
}
}
« no previous file with comments | « Source/bindings/core/v8/ScriptController.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698