Source/core/testing/UnionTypesTest.cpp - Issue 713683003: IDL: Support optional union type arguments with default values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/UnionTypesTest.cpp

Issue 713683003: IDL: Support optional union type arguments with default values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add unit tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/core/testing/UnionTypesTest.idl » ('j') | Source/core/testing/UnionTypesTest.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/testing/UnionTypesTest.cpp

diff --git a/Source/core/testing/UnionTypesTest.cpp b/Source/core/testing/UnionTypesTest.cpp

index d03e2985e6f82c2575e5dec4314e143f609aed86..5e34b96cf0ad2e699b7e18fd6d53499783c32285 100644

--- a/Source/core/testing/UnionTypesTest.cpp

+++ b/Source/core/testing/UnionTypesTest.cpp

@@ -40,7 +40,8 @@ void UnionTypesTest::setDoubleOrStringAttribute(const DoubleOrString& doubleOrSt

String UnionTypesTest::doubleOrStringArg(DoubleOrString& doubleOrString)

{

- ASSERT(!doubleOrString.isNull());

+ if (doubleOrString.isNull())

+ return "null is passed";

if (doubleOrString.isDouble())

return "double is passed: " + String::numberToStringECMAScript(doubleOrString.getAsDouble());

if (doubleOrString.isString())

« no previous file with comments | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/core/testing/UnionTypesTest.idl » ('j') | Source/core/testing/UnionTypesTest.idl » ('J')