Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 713643002: Revert "Adding GCM support to the copresence component. The Copresence server can push directives (… (Closed)

Created:
6 years, 1 month ago by kareng
Modified:
6 years, 1 month ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, zea+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Project:
chromium
Visibility:
Public.

Description

Revert "Adding GCM support to the copresence component. The Copresence server can push directives (and messages, though they are not yet handled) over GCM." This reverts commit 19b4f6371c68fe1627c2b75ca5ec8a4061796e58. Revert "[GCM] Fetching OAuth2 tokens periodically in account tracker" This reverts commit ede4117a85d34a1c117169d538b297020e69de87. Revert "Fixing all of problems found by vc++ /analyze in GCM code" This reverts commit 3e021981ccc2be8de7443ff1a18439551b22ea75. Revert "PPAPI: Make GetProxiedInterface not re-enter the plugin" This reverts commit a17de8faa97ca33d1e58e08392dbdc3e316d6cbe. BUG= Committed: https://chromium.googlesource.com/chromium/src/+/e529d5bfcc33d8e6cb65f985a0c36b999067e609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -811 lines) Patch
M chrome/browser/extensions/api/copresence/copresence_api.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/copresence/copresence_api.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/services/gcm/gcm_account_tracker.h View 4 chunks +2 lines, -26 lines 0 comments Download
M chrome/browser/services/gcm/gcm_account_tracker.cc View 10 chunks +18 lines, -72 lines 0 comments Download
M chrome/browser/services/gcm/gcm_account_tracker_unittest.cc View 8 chunks +3 lines, -87 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/copresence.gypi View 3 chunks +0 lines, -11 lines 0 comments Download
M components/copresence/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/copresence/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/copresence/copresence_manager_impl.h View 2 chunks +4 lines, -6 lines 0 comments Download
M components/copresence/copresence_manager_impl.cc View 2 chunks +3 lines, -10 lines 0 comments Download
D components/copresence/handlers/gcm_handler.h View 1 chunk +0 lines, -78 lines 0 comments Download
D components/copresence/handlers/gcm_handler.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D components/copresence/handlers/gcm_handler_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M components/copresence/proto/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/copresence/proto/data.proto View 1 chunk +0 lines, -4 lines 0 comments Download
D components/copresence/proto/push_message.proto View 1 chunk +0 lines, -20 lines 0 comments Download
M components/copresence/public/copresence_delegate.h View 2 chunks +0 lines, -8 lines 0 comments Download
M components/copresence/rpc/rpc_handler.h View 5 chunks +2 lines, -10 lines 0 comments Download
M components/copresence/rpc/rpc_handler.cc View 12 chunks +26 lines, -91 lines 0 comments Download
M components/copresence/rpc/rpc_handler_unittest.cc View 5 chunks +40 lines, -8 lines 0 comments Download
D components/copresence/test/fake_directive_handler.h View 1 chunk +0 lines, -49 lines 0 comments Download
D components/copresence/test/fake_directive_handler.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M components/gcm_driver/gcm_client_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/gcm_driver/gcm_client_impl.cc View 2 chunks +1 line, -6 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 2 chunks +1 line, -6 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/host_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 2 chunks +4 lines, -8 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kareng
6 years, 1 month ago (2014-11-08 14:57:13 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e529d5bfcc33d8e6cb65f985a0c36b999067e609.

Powered by Google App Engine
This is Rietveld 408576698