Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 713623002: Stabilize and re-enable TabCaptureApiPixelTest.EndToEnd. (Closed)

Created:
6 years, 1 month ago by miu
Modified:
6 years, 1 month ago
Reviewers:
hubbe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Stabilize and re-enable TabCaptureApiPixelTest.EndToEnd. This takes the lessons learned from stabilizing the CastStreamingApiTest.EndToEnd test and rewrites much of the TabCaptureApiPixelTest.EndToEnd JavaScript code to match. In addition, the test is now split into separate browser test fixtures to differentiate between failures due to Chromium commits vs. WebRTC rolls. BUG=367349, 396413, 406051 Committed: https://crrev.com/5dd13bd3a186330de2fea378f0c8b190b96a0515 Cr-Commit-Position: refs/heads/master@{#304335}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -149 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 3 chunks +50 lines, -13 lines 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/end_to_end.html View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/end_to_end.js View 1 chunk +183 lines, -132 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
miu
hubbe: PTAL.
6 years, 1 month ago (2014-11-11 00:24:18 UTC) #3
hubbe
lgtm
6 years, 1 month ago (2014-11-15 01:15:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713623002/20001
6 years, 1 month ago (2014-11-15 01:16:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 1 month ago (2014-11-15 02:10:26 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 02:14:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dd13bd3a186330de2fea378f0c8b190b96a0515
Cr-Commit-Position: refs/heads/master@{#304335}

Powered by Google App Engine
This is Rietveld 408576698