Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 713573003: Fixing all of problems found by vc++ /analyze in GCM code (Closed)

Created:
6 years, 1 month ago by fgorski
Modified:
6 years, 1 month ago
CC:
chromium-reviews, zea+watch_chromium.org, brucedawson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing all of problems found by vc++ /analyze in GCM code There was only a minor (harmless) case of variable shadowing. BUG=427616 R=zea@chromium.org Committed: https://crrev.com/3e021981ccc2be8de7443ff1a18439551b22ea75 Cr-Commit-Position: refs/heads/master@{#303338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M google_apis/gcm/engine/gcm_store_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brucedawson
lgtm
6 years, 1 month ago (2014-11-07 23:45:31 UTC) #3
Nicolas Zea
lgtm
6 years, 1 month ago (2014-11-07 23:45:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713573003/1
6 years, 1 month ago (2014-11-07 23:50:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-08 00:36:50 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3e021981ccc2be8de7443ff1a18439551b22ea75 Cr-Commit-Position: refs/heads/master@{#303338}
6 years, 1 month ago (2014-11-08 00:37:24 UTC) #8
matthewyuan
6 years, 1 month ago (2014-11-08 22:27:47 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/712793003/ by matthewyuan@chromium.org.

The reason for reverting is: Reverting since it's causing a crash on canary..

Powered by Google App Engine
This is Rietveld 408576698