Issue 71353011: Roll forward r30205.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 71353011: Roll forward r30205. (Closed)

Created:
7 years, 1 month ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Roll forward r30205. Unlike previous versions of this CL, the debug info will only be printed when running directory_watcher/mac_os_test, so it won't break the pub bots. R=rnystrom@google.com BUG=15042 Committed: https://code.google.com/p/dart/source/detail?r=30254

Patch Set 1 #

Total comments: 1

Patch Set 2 : code review #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -3 lines)			Patch
M	pkg/pkg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/watcher/lib/src/directory_watcher/mac_os.dart	View	1	9 chunks	+77 lines, -2 lines	0 comments	Download
M	pkg/watcher/test/directory_watcher/mac_os_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion then LGTM. https://codereview.chromium.org/71353011/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart File pkg/watcher/lib/src/directory_watcher/mac_os.dart (right): https://codereview.chromium.org/71353011/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart#newcode410 pkg/watcher/lib/src/directory_watcher/mac_os.dart:410: /// Return a human-friendly string ...

7 years, 1 month ago (2013-11-13 21:48:33 UTC) #2

nweiz

7 years, 1 month ago (2013-11-13 21:57:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30254 (presubmit successful).

Expand Messages | Collapse Messages