Fix WebRTC logging so that logs from libpeerconnection make it to the log.

third_party/libjingle/overrides/talk/base/logging.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "third_party/libjingle/overrides/talk/base/logging.h"
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
 #include <CoreServices/CoreServices.h>
 #endif  // OS_MACOSX
 
@@ skipping 13 matching lines @@
 // ~DiagnosticLogMessage. Note that the second parameter to the LAZY_STREAM
 // macro is true since the filter check has already been done for
 // DIAGNOSTIC_LOG.
 #define LOG_LAZY_STREAM_DIRECT(file_name, line_number, sev) \
   LAZY_STREAM(logging::LogMessage(file_name, line_number, \
                                   -sev).stream(), true)
 
 namespace talk_base {
 
 void (*g_logging_delegate_function)(const std::string&) = NULL;
+void (*g_extra_logging_init_function)(
+    void (*logging_delegate_function)(const std::string&)) = NULL;
 #ifndef NDEBUG
 COMPILE_ASSERT(sizeof(base::subtle::Atomic32) == sizeof(base::PlatformThreadId),
                atomic32_not_same_size_as_platformthreadid);
 base::subtle::Atomic32 g_init_logging_delegate_thread_id = 0;
 #endif
 
 /////////////////////////////////////////////////////////////////////////////
 // Constant Labels
 /////////////////////////////////////////////////////////////////////////////
 
@@ skipping 257 matching lines @@
   // This function may be called with the same argument several times if the
   // page is reloaded or there are several PeerConnections on one page with
   // logging enabled. This is OK, we simply don't have to do anything.
   if (delegate == g_logging_delegate_function)
     return;
   CHECK(!g_logging_delegate_function);
 #ifdef NDEBUG
   IPAddress::set_strip_sensitive(true);
 #endif
   g_logging_delegate_function = delegate;
+
+  if (g_extra_logging_init_function)
+    g_extra_logging_init_function(delegate);
+}
+
+void SetExtraLoggingInit(
+    void (*function)(void (*delegate)(const std::string&))) {

[tommi (sloooow) - chröme, 2013/11/14 08:12:18]

nit: it would be more readable to have a typedef for at least the delegate
function.  for both would be better still imho.  I'm fine with a TODO on that if
you agree.

[Henrik Grunell, 2013/11/14 09:04:08]

Agree, added todo in the header.

+  CHECK(function);
+  CHECK(!g_extra_logging_init_function);
+  g_extra_logging_init_function = function;
 }
 
 }  // namespace talk_base