Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 71353006: Telemetry: Filter invalid frame lengths from SurfaceFlinger data. (Closed)

Created:
7 years, 1 month ago by Dominik Grewe
Modified:
7 years, 1 month ago
Reviewers:
bulach
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Telemetry: Filter invalid frame lengths from SurfaceFlinger data. We use the SurfaceFlinger data to compute the lengths of the frames (normalized to vsyncs). Sometimes the data is inconsistent and we get two frames that are less than 1 vsync apart. Filter out these frame lengths (threshold length is currently 0.5 vsyncs) and print a warning. BUG=318093 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235675

Patch Set 1 #

Patch Set 2 : Rename methods. #

Patch Set 3 : Move filter to _GetNormalizedDeltas; add unit tests. #

Total comments: 2

Patch Set 4 : Clean up. #

Patch Set 5 : small fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -3 lines) Patch
M build/android/pylib/perf/surface_stats_collector.py View 1 2 3 4 4 chunks +14 lines, -3 lines 0 comments Download
A build/android/pylib/perf/surface_stats_collector_unittest.py View 1 2 3 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Dominik Grewe
PTAL, thanks.
7 years, 1 month ago (2013-11-13 17:39:53 UTC) #1
Dominik Grewe
Updated and added some tests according to our discussion. Also fixed an off-by-one bug in ...
7 years, 1 month ago (2013-11-14 18:01:04 UTC) #2
bulach
lgtm, neat, thanks! just some nits below: https://codereview.chromium.org/71353006/diff/60001/build/android/pylib/perf/surface_stats_collector_unittest.py File build/android/pylib/perf/surface_stats_collector_unittest.py (right): https://codereview.chromium.org/71353006/diff/60001/build/android/pylib/perf/surface_stats_collector_unittest.py#newcode42 build/android/pylib/perf/surface_stats_collector_unittest.py:42: results = ...
7 years, 1 month ago (2013-11-15 12:11:19 UTC) #3
Dominik Grewe
On 2013/11/15 12:11:19, bulach wrote: > lgtm, neat, thanks! just some nits below: > > ...
7 years, 1 month ago (2013-11-15 13:40:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/71353006/120001
7 years, 1 month ago (2013-11-15 13:41:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/71353006/340001
7 years, 1 month ago (2013-11-15 15:38:09 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=27601
7 years, 1 month ago (2013-11-15 16:29:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/71353006/340001
7 years, 1 month ago (2013-11-15 16:42:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/71353006/340001
7 years, 1 month ago (2013-11-15 22:23:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/71353006/340001
7 years, 1 month ago (2013-11-16 01:03:50 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 08:53:12 UTC) #11
Message was sent while issue was closed. 
Change committed as 235675

Powered by Google App Engine
This is Rietveld 408576698