Don't allow trailing data when creating an RSAPrivateKey.

Don't allow trailing data when creating an RSAPrivateKey.

CreateFromPrivateKeyInfo should not silently discard data after the
PrivateKeyInfo.

BUG=432279
Committed: https://crrev.com/c6761098bdf74868efe2ba255e238f3e4c06de72
Cr-Commit-Position: refs/heads/master@{#305503}

[davidben, 2014-11-11 23:41:59]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2014-11-22 01:13:57]

lgtm

https://codereview.chromium.org/713523004/diff/20001/crypto/rsa_private_key_n...
File crypto/rsa_private_key_nss.cc (right):

https://codereview.chromium.org/713523004/diff/20001/crypto/rsa_private_key_n...
crypto/rsa_private_key_nss.cc:289: SECItem input_item, der_private_key_info;
nit: I tend to prefer we don't use this style in //net, as it can make it
visually difficult to find the type of a given variable.

[davidben, 2014-11-24 20:23:59]

https://codereview.chromium.org/713523004/diff/20001/crypto/rsa_private_key_n...
File crypto/rsa_private_key_nss.cc (right):

https://codereview.chromium.org/713523004/diff/20001/crypto/rsa_private_key_n...
crypto/rsa_private_key_nss.cc:289: SECItem input_item, der_private_key_info;
On 2014/11/22 01:13:57, Ryan Sleevi wrote:
> nit: I tend to prefer we don't use this style in //net, as it can make it
> visually difficult to find the type of a given variable.

Done.

[davidben, 2014-11-24 20:24:27]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-11-24 20:25:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/713523004/40001

[commit-bot: I haz the power, 2014-11-24 21:54:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-24 21:55:03]

Patchset 3 (id:??) landed as
https://crrev.com/c6761098bdf74868efe2ba255e238f3e4c06de72
Cr-Commit-Position: refs/heads/master@{#305503}