Change mojo application name to {name}.mojo

Change mojo application name to {name}.mojo

Also remove obsolete reference to gyp files.

R=abarth@chromium.org, brettw@chromium.org, aa@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/2150a7bd73490df3588b3a8aa3e2443ad7afcad7

[abarth-chromium, 2014-11-07 16:00:39]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2014-11-07 16:00:39]

//sky/* LGTM

[Aaron Boodman, 2014-11-07 18:02:46]

aa@chromium.org changed reviewers:
+ brettw@chromium.org

[Aaron Boodman, 2014-11-07 18:02:47]

https://codereview.chromium.org/713513002/diff/1/mojo/public/mojo_application...
File mojo/public/mojo_application.gni (right):

https://codereview.chromium.org/713513002/diff/1/mojo/public/mojo_application...
mojo/public/mojo_application.gni:1: # Copyright 2014 The Chromium Authors. All
rights reserved.
You should get brettw to give this a once-over.

https://codereview.chromium.org/713513002/diff/1/mojo/public/mojo_application...
mojo/public/mojo_application.gni:7: template("mojo_binary_application") {
"binary" is so fuzzy. Is a java application binary? Is a go application? Is
pnacl? How about mojo_native_application?

https://codereview.chromium.org/713513002/diff/1/mojo/public/mojo_application...
mojo/public/mojo_application.gni:29: if (defined(invoker.cflags)) {
Do we use all of these params right now? There are a lot of them, perhaps only
do the ones we actually use right now.

[DaveMoore, 2014-11-07 18:24:39]

davemoore@chromium.org changed reviewers:
+ davemoore@chromium.org

[DaveMoore, 2014-11-07 18:24:41]

https://codereview.chromium.org/713513002/diff/1/mojo/public/mojo_application...
File mojo/public/mojo_application.gni (right):

https://codereview.chromium.org/713513002/diff/1/mojo/public/mojo_application...
mojo/public/mojo_application.gni:7: template("mojo_binary_application") {
On 2014/11/07 18:02:47, Aaron Boodman wrote:
> "binary" is so fuzzy. Is a java application binary? Is a go application? Is
> pnacl? How about mojo_native_application?

Why not simply mojo_application? What other types are there going to be?

[qsr, 2014-11-12 10:05:00]

brettw: Can you take a look? Thanks.

https://codereview.chromium.org/713513002/diff/1/mojo/public/mojo_application...
File mojo/public/mojo_application.gni (right):

https://codereview.chromium.org/713513002/diff/1/mojo/public/mojo_application...
mojo/public/mojo_application.gni:1: # Copyright 2014 The Chromium Authors. All
rights reserved.
On 2014/11/07 18:02:47, Aaron Boodman wrote:
> You should get brettw to give this a once-over.

Done.

https://codereview.chromium.org/713513002/diff/1/mojo/public/mojo_application...
mojo/public/mojo_application.gni:7: template("mojo_binary_application") {
On 2014/11/07 18:02:47, Aaron Boodman wrote:
> "binary" is so fuzzy. Is a java application binary? Is a go application? Is
> pnacl? How about mojo_native_application?

Done.

https://codereview.chromium.org/713513002/diff/1/mojo/public/mojo_application...
mojo/public/mojo_application.gni:29: if (defined(invoker.cflags)) {
On 2014/11/07 18:02:47, Aaron Boodman wrote:
> Do we use all of these params right now? There are a lot of them, perhaps only
> do the ones we actually use right now.

 I put all the flags used by shared_library. This is part of public, so might be
used outside of this repo, so better be exhaustive.

 I wanted to be able to do something like

arguments = [
  "cflags",
  ...
]

foreach(var, arguments) {
  if (defined(invoker[var])) {
    context[var] = invoker[var]
  }
}

but none of this works :(

[brettw, 2014-11-14 18:53:35]

lgtm

[qsr, 2014-11-14 20:49:37]

Committed patchset #3 (id:40001) manually as
2150a7bd73490df3588b3a8aa3e2443ad7afcad7 (presubmit successful).