Accelerator Key's are not visible for Left and right Rotation in pdf context menu.

Accelerator Key's are not visible for Left and right Rotation in pdf context menu.

Accelerator key's should be visible in context menu,so that user learn and
can use these Accelerator keys for rotation without opening context menu
everytime.
Changes done to show Accelerator key for rotationCW and rotationCCW.

BUG=431313
Committed: https://crrev.com/9927de9d47b5232fe0a18ee2b3a0abc0a660215f
Cr-Commit-Position: refs/heads/master@{#303591}

[Deepak, 2014-11-07 15:09:01]

deepak.m1@samsung.com changed reviewers:
+ avi@chromium.org, msw@chromium.org, raymes@chromium.org

[Deepak, 2014-11-07 15:09:01]

PTAL.

[Avi (use Gerrit), 2014-11-07 16:23:52]

I guess so. I'm not a Views person.

[Deepak, 2014-11-08 05:41:36]

deepak.m1@samsung.com changed reviewers:
+ andresantoso@chromium.org

[Deepak, 2014-11-08 05:41:36]

@Andresantoso
I have found that you have worked on this file,I have done changes to show
Accelerator for rotation in PDF context menu, so that user learn and can rotate
PDF without opening context menu.
PTAL.

[Andre, 2014-11-08 07:14:57]

On 2014/11/08 05:41:36, Deepak wrote:
> @Andresantoso
> I have found that you have worked on this file,I have done changes to show
> Accelerator for rotation in PDF context menu, so that user learn and can
rotate
> PDF without opening context menu.
> PTAL.

I'm not really a Views person either, and I'm not owner.
OWNERS file says msw@, pkasting@, or sky@.

[Deepak, 2014-11-08 08:45:03]

On 2014/11/08 07:14:57, Andre wrote:
> On 2014/11/08 05:41:36, Deepak wrote:
> > @Andresantoso
> > I have found that you have worked on this file,I have done changes to show
> > Accelerator for rotation in PDF context menu, so that user learn and can
> rotate
> > PDF without opening context menu.
> > PTAL.
> 
> I'm not really a Views person either, and I'm not owner.
> OWNERS file says msw@, pkasting@, or sky@.

I know that @msw is owner of this file, I have already added him.
I tried:
"git shortlog -s -n
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc"
and found you have done more changes in this file so just wanted to know your
opinion
for my changes.As it is straight forward, adding accelerator for rotation item.
Thanks

[Andre, 2014-11-09 05:00:55]

On 2014/11/08 08:45:03, Deepak wrote:
> On 2014/11/08 07:14:57, Andre wrote:
> > On 2014/11/08 05:41:36, Deepak wrote:
> > > @Andresantoso
> > > I have found that you have worked on this file,I have done changes to show
> > > Accelerator for rotation in PDF context menu, so that user learn and can
> > rotate
> > > PDF without opening context menu.
> > > PTAL.
> > 
> > I'm not really a Views person either, and I'm not owner.
> > OWNERS file says msw@, pkasting@, or sky@.
> 
> I know that @msw is owner of this file, I have already added him.
> I tried:
> "git shortlog -s -n
>
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc"
> and found you have done more changes in this file so just wanted to know your
> opinion
> for my changes.As it is straight forward, adding accelerator for rotation
item.
> Thanks

I changed this file for unrelated code, I don't really know what to say about
this change sorry.

[Deepak, 2014-11-10 02:43:15]

On 2014/11/09 05:00:55, Andre wrote:
> On 2014/11/08 08:45:03, Deepak wrote:
> > On 2014/11/08 07:14:57, Andre wrote:
> > > On 2014/11/08 05:41:36, Deepak wrote:
> > > > @Andresantoso
> > > > I have found that you have worked on this file,I have done changes to
show
> > > > Accelerator for rotation in PDF context menu, so that user learn and can
> > > rotate
> > > > PDF without opening context menu.
> > > > PTAL.
> > > 
> > > I'm not really a Views person either, and I'm not owner.
> > > OWNERS file says msw@, pkasting@, or sky@.
> > 
> > I know that @msw is owner of this file, I have already added him.
> > I tried:
> > "git shortlog -s -n
> >
>
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc"
> > and found you have done more changes in this file so just wanted to know
your
> > opinion
> > for my changes.As it is straight forward, adding accelerator for rotation
> item.
> > Thanks
> 
> I changed this file for unrelated code, I don't really know what to say about
> this change sorry.

@msw
PTAL.

[msw, 2014-11-10 17:58:46]

The Print and Inspect Element entries are also missing accelerator labels, but
this seems like an okay minor incremental improvement, lgtm.

[Deepak, 2014-11-11 02:36:33]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2014-11-11 02:38:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/713503002/1

[Deepak, 2014-11-11 02:40:08]

On 2014/11/10 17:58:46, msw wrote:
> The Print and Inspect Element entries are also missing accelerator labels, but
> this seems like an okay minor incremental improvement, lgtm.

I agree with you.
Should I add also add accelerator labels for "Print" and "Inspect Element" also.
please suggest.

[msw, 2014-11-11 03:36:17]

On 2014/11/11 02:40:08, Deepak wrote:
> On 2014/11/10 17:58:46, msw wrote:
> > The Print and Inspect Element entries are also missing accelerator labels,
but
> > this seems like an okay minor incremental improvement, lgtm.
> 
> I agree with you.
> Should I add also add accelerator labels for "Print" and "Inspect Element"
also.
> please suggest.

Go ahead, you can do that a followup CL; ping for re-review if you do it here.

[commit-bot: I haz the power, 2014-11-11 04:13:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-11 04:13:59]

Patchset 1 (id:??) landed as
https://crrev.com/9927de9d47b5232fe0a18ee2b3a0abc0a660215f
Cr-Commit-Position: refs/heads/master@{#303591}