Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 713483002: DevTools: disable filters bar when switching Timeline to flame chart mode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js
index 676950fc42c3d0cd7be8860129fd912e9de552bc..fbb4829dd916a6ad4b8f13a7a3f84d8f78d15f5a 100644
--- a/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -602,10 +602,15 @@ WebInspector.TimelinePanel.prototype = {
else
this._overviewControls.push(new WebInspector.TimelineEventOverview(this._model, this._uiUtils));
- if (this._tracingTimelineModel && this._flameChartEnabledSetting.get())
+ if (this._tracingTimelineModel && this._flameChartEnabledSetting.get()) {
+ this._filterBar.filterButton().setEnabled(false);
+ this._filtersContainer.classList.toggle("hidden", true);
this._addModeView(new WebInspector.TimelineFlameChart(this, this._tracingTimelineModel, this._frameModel()));
- else
+ } else {
+ this._filterBar.filterButton().setEnabled(true);
+ this._filtersContainer.classList.toggle("hidden", !this._filterBar.filtersToggled());
this._addModeView(this._timelineView());
+ }
if (this._captureMemorySetting.get()) {
if (!isFrameMode) // Frame mode skews time, don't render aux overviews.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698