Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 713483002: DevTools: disable filters bar when switching Timeline to flame chart mode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 584 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 595
596 var isFrameMode = this._overviewModeSetting.get() === WebInspector.Timel inePanel.OverviewMode.Frames; 596 var isFrameMode = this._overviewModeSetting.get() === WebInspector.Timel inePanel.OverviewMode.Frames;
597 this._removeAllModeViews(); 597 this._removeAllModeViews();
598 this._overviewControls = []; 598 this._overviewControls = [];
599 599
600 if (isFrameMode) 600 if (isFrameMode)
601 this._overviewControls.push(new WebInspector.TimelineFrameOverview(t his._model, this._frameModel())); 601 this._overviewControls.push(new WebInspector.TimelineFrameOverview(t his._model, this._frameModel()));
602 else 602 else
603 this._overviewControls.push(new WebInspector.TimelineEventOverview(t his._model, this._uiUtils)); 603 this._overviewControls.push(new WebInspector.TimelineEventOverview(t his._model, this._uiUtils));
604 604
605 if (this._tracingTimelineModel && this._flameChartEnabledSetting.get()) 605 if (this._tracingTimelineModel && this._flameChartEnabledSetting.get()) {
606 this._filterBar.filterButton().setEnabled(false);
607 this._filtersContainer.classList.toggle("hidden", true);
606 this._addModeView(new WebInspector.TimelineFlameChart(this, this._tr acingTimelineModel, this._frameModel())); 608 this._addModeView(new WebInspector.TimelineFlameChart(this, this._tr acingTimelineModel, this._frameModel()));
607 else 609 } else {
610 this._filterBar.filterButton().setEnabled(true);
611 this._filtersContainer.classList.toggle("hidden", !this._filterBar.f iltersToggled());
608 this._addModeView(this._timelineView()); 612 this._addModeView(this._timelineView());
613 }
609 614
610 if (this._captureMemorySetting.get()) { 615 if (this._captureMemorySetting.get()) {
611 if (!isFrameMode) // Frame mode skews time, don't render aux overvi ews. 616 if (!isFrameMode) // Frame mode skews time, don't render aux overvi ews.
612 this._overviewControls.push(new WebInspector.TimelineMemoryOverv iew(this._model, this._uiUtils)); 617 this._overviewControls.push(new WebInspector.TimelineMemoryOverv iew(this._model, this._uiUtils));
613 this._addModeView(new WebInspector.MemoryCountersGraph(this, this._m odel, this._uiUtils)); 618 this._addModeView(new WebInspector.MemoryCountersGraph(this, this._m odel, this._uiUtils));
614 } 619 }
615 620
616 if (this._capturePowerSetting && this._capturePowerSetting.get() && 621 if (this._capturePowerSetting && this._capturePowerSetting.get() &&
617 WebInspector.targetManager.mainTarget().hasCapability(WebInspector.T arget.Capabilities.CanProfilePower)) { 622 WebInspector.targetManager.mainTarget().hasCapability(WebInspector.T arget.Capabilities.CanProfilePower)) {
618 if (!isFrameMode) // Frame mode skews time, don't render aux overvi ews. 623 if (!isFrameMode) // Frame mode skews time, don't render aux overvi ews.
(...skipping 897 matching lines...) Expand 10 before | Expand all | Expand 10 after
1516 1521
1517 WebInspector.TimelinePanelFactory.prototype = { 1522 WebInspector.TimelinePanelFactory.prototype = {
1518 /** 1523 /**
1519 * @return {!WebInspector.Panel} 1524 * @return {!WebInspector.Panel}
1520 */ 1525 */
1521 createPanel: function() 1526 createPanel: function()
1522 { 1527 {
1523 return WebInspector.TimelinePanel._instance(); 1528 return WebInspector.TimelinePanel._instance();
1524 } 1529 }
1525 } 1530 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698