Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 713483002: DevTools: disable filters bar when switching Timeline to flame chart mode (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: disable filters bar when switching Timeline to flame chart mode The filters status bar button gets disabled and the filters bar is hidden. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yurys
6 years, 1 month ago (2014-11-07 14:50:27 UTC) #2
loislo
lgtm
6 years, 1 month ago (2014-11-07 14:51:03 UTC) #4
loislo
lgtm
6 years, 1 month ago (2014-11-07 14:51:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713483002/1
6 years, 1 month ago (2014-11-07 14:51:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713483002/1
6 years, 1 month ago (2014-11-07 14:57:41 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 15:55:27 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184974

Powered by Google App Engine
This is Rietveld 408576698