Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 713453003: De-flake window.location shadowing layout tests. (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
Nate Chapin
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

De-flake window.location shadowing layout tests. Use onmessage instead of the iframe onload event, since the test itself triggers navigation. Depending on the timing, the iframe onload handler may run more than once. BUG=381464 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/Location/resources/pass.html View 1 chunk +8 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/Location/window-shadow-location-using-string.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dcheng
Thanks for the key insight--I was looking at the test from completely the wrong perspective.
6 years, 1 month ago (2014-11-11 18:57:50 UTC) #2
Nate Chapin
lgtm
6 years, 1 month ago (2014-11-11 19:11:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713453003/1
6 years, 1 month ago (2014-11-11 19:29:42 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 20:36:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185142

Powered by Google App Engine
This is Rietveld 408576698