Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 713443003: While loading a page in tabmanager mode, control should come on content page hiding the tabmanager … (Closed)

Created:
6 years, 1 month ago by divya.bansal
Modified:
6 years, 1 month ago
Reviewers:
Bernhard Bauer, Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

While loading a page in tabmanager mode, control should come on content page hiding the tabmanager mode. Currently in TabManager window, if we try to load a url it gets loaded in background.These changes transfer the control to content from tab manager window, if a url is getting loaded. Signed-off-by: divyabansal <divya.bansal@samsung.com>; BUG=429977 Committed: https://crrev.com/d52161641eceb225c752261eb75f07556a2d24a4 Cr-Commit-Position: refs/heads/master@{#303223}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
divya.bansal
PTAL
6 years, 1 month ago (2014-11-07 10:50:51 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/713443003/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java File chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java (right): https://codereview.chromium.org/713443003/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java#newcode168 chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:168: if (mTabManager.isTabSwitcherVisible()) { This should come before the comment, ...
6 years, 1 month ago (2014-11-07 11:02:39 UTC) #3
divya.bansal
PTAL https://codereview.chromium.org/713443003/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java File chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java (right): https://codereview.chromium.org/713443003/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java#newcode168 chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:168: if (mTabManager.isTabSwitcherVisible()) { On 2014/11/07 11:02:39, Bernhard Bauer ...
6 years, 1 month ago (2014-11-07 11:38:34 UTC) #4
Bernhard Bauer
lgtm
6 years, 1 month ago (2014-11-07 11:40:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713443003/20001
6 years, 1 month ago (2014-11-07 11:42:03 UTC) #7
divya.bansal
On 2014/11/07 11:42:03, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 1 month ago (2014-11-07 11:47:57 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-07 12:28:41 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 12:29:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d52161641eceb225c752261eb75f07556a2d24a4
Cr-Commit-Position: refs/heads/master@{#303223}

Powered by Google App Engine
This is Rietveld 408576698