Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4799)

Unified Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 7134035: Make an inserted selected tab selected before calling TabInsertedAt on observers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename foreground to active, and function style Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.h
diff --git a/chrome/browser/extensions/extension_tabs_module.h b/chrome/browser/extensions/extension_tabs_module.h
index b406a9e5fb10e30a272de64342033cc3e11c9ec5..b2d7034bced76a2972ae685b1665ed3057fe5904 100644
--- a/chrome/browser/extensions/extension_tabs_module.h
+++ b/chrome/browser/extensions/extension_tabs_module.h
@@ -32,13 +32,17 @@ DictionaryValue* CreateTabValue(const TabContents* tab_contents);
DictionaryValue* CreateTabValue(const TabContents* tab_contents,
TabStripModel* tab_strip,
int tab_index);
+// Create a tab value, overriding its kSelectedKey to the provided boolean.
+DictionaryValue* CreateTabValueActive(const TabContents* tab_contents,
+ bool active);
DictionaryValue* CreateWindowValue(const Browser* browser,
bool populate_tabs);
// Gets the |tab_strip_model| and |tab_index| for the given |tab_contents|.
bool GetTabStripModel(const TabContents* tab_contents,
TabStripModel** tab_strip_model,
int* tab_index);
-bool GetDefaultTab(Browser* browser, TabContentsWrapper** contents,
+bool GetDefaultTab(Browser* browser,
+ TabContentsWrapper** contents,
int* tab_id);
// Any out parameter (|browser|, |tab_strip|, |contents|, & |tab_index|) may
// be NULL and will not be set within the function.
@@ -120,7 +124,8 @@ class UpdateTabFunction : public AsyncExtensionFunction,
virtual ~UpdateTabFunction() {}
virtual bool RunImpl();
virtual bool OnMessageReceived(const IPC::Message& message);
- void OnExecuteCodeFinished(int request_id, bool success,
+ void OnExecuteCodeFinished(int request_id,
+ bool success,
const std::string& error);
DECLARE_EXTENSION_FUNCTION_NAME("tabs.update")
};
« no previous file with comments | « chrome/browser/extensions/extension_browser_event_router.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698