Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: chrome/browser/extensions/extension_browser_event_router.h

Issue 7134035: Make an inserted selected tab selected before calling TabInsertedAt on observers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename foreground to active, and function style Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_browser_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_browser_event_router.h
diff --git a/chrome/browser/extensions/extension_browser_event_router.h b/chrome/browser/extensions/extension_browser_event_router.h
index dfcc48924c5a0002427fae859cff3778f0d26741..6136f6ecf6d51eeee4e12012664b7b0635494de5 100644
--- a/chrome/browser/extensions/extension_browser_event_router.h
+++ b/chrome/browser/extensions/extension_browser_event_router.h
@@ -59,7 +59,7 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver,
// TabStripModelObserver
virtual void TabInsertedAt(TabContentsWrapper* contents, int index,
- bool foreground);
+ bool active);
virtual void TabClosingAt(TabStripModel* tab_strip_model,
TabContentsWrapper* contents,
int index);
@@ -97,7 +97,7 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver,
const NotificationDetails& details);
private:
// "Synthetic" event. Called from TabInsertedAt if new tab is detected.
- void TabCreatedAt(TabContents* contents, int index, bool foreground);
+ void TabCreatedAt(TabContents* contents, int index, bool active);
// Internal processing of tab updated events. Is called by both TabChangedAt
// and Observe/NAV_ENTRY_COMMITTED.
@@ -118,7 +118,8 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver,
void DispatchEventWithTab(Profile* profile,
const std::string& extension_id,
const char* event_name,
- const TabContents* tab_contents);
+ const TabContents* tab_contents,
+ bool active);
void DispatchSimpleBrowserEvent(Profile* profile,
const int window_id,
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_browser_event_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698