chrome/test/data/extensions/api_test/tabs/basics/events.html - Issue 7134035: Make an inserted selected tab selected before calling TabInsertedAt on observers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/tabs/basics/events.html

Issue 7134035: Make an inserted selected tab selected before calling TabInsertedAt on observers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rename foreground to active, and function style Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/api_test/tabs/basics/events.html

diff --git a/chrome/test/data/extensions/api_test/tabs/basics/events.html b/chrome/test/data/extensions/api_test/tabs/basics/events.html

index 98e0d03555405f28b3d904ce2b2736ee01af5e9d..2edc492fcfbccfc12a03751bf9a83e01b5aba371 100644

--- a/chrome/test/data/extensions/api_test/tabs/basics/events.html

+++ b/chrome/test/data/extensions/api_test/tabs/basics/events.html

@@ -18,9 +18,7 @@ chrome.test.runTests([

chrome.test.listenOnce(chrome.tabs.onCreated, function(tab) {

assertEq(pageUrl("f"), tab.url);

otherTabId = tab.id;

- // TODO(jstritar): http://crbug.com/59194 tab.selected is always false

- // when passed into chrome.tabs.onCreated listener

- //assertEq(true, tab.selected);

+ assertEq(true, tab.selected);

});

chrome.tabs.create({"windowId": firstWindowId, "url": pageUrl("f"),

« no previous file with comments | « chrome/browser/extensions/extension_tabs_module.cc ('k') | no next file » | no next file with comments »