Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: content/browser/web_contents/web_contents_view_mac.mm

Issue 713353002: Disable use of occlusion APIs while bugs are fixed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Carbon/Carbon.h> 5 #import <Carbon/Carbon.h>
6 6
7 #import "content/browser/web_contents/web_contents_view_mac.h" 7 #import "content/browser/web_contents/web_contents_view_mac.h"
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 587 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 598
599 - (void)viewWillMoveToWindow:(NSWindow*)newWindow { 599 - (void)viewWillMoveToWindow:(NSWindow*)newWindow {
600 NSWindow* oldWindow = [self window]; 600 NSWindow* oldWindow = [self window];
601 601
602 NSNotificationCenter* notificationCenter = 602 NSNotificationCenter* notificationCenter =
603 [NSNotificationCenter defaultCenter]; 603 [NSNotificationCenter defaultCenter];
604 604
605 // Occlusion notification APIs are new in Mavericks. 605 // Occlusion notification APIs are new in Mavericks.
606 bool supportsOcclusionAPIs = base::mac::IsOSMavericksOrLater(); 606 bool supportsOcclusionAPIs = base::mac::IsOSMavericksOrLater();
607 607
608 // Use of occlusion APIs is causing bugs:
609 // http://crbug.com/430968: focus set incorrectly.
610 // http://crbug.com/431272: flashes of incorrect content.
611 // http://crbug.com/310374: white flashes (comment 22).
612 supportsOcclusionAPIs = false;
613
608 if (supportsOcclusionAPIs) { 614 if (supportsOcclusionAPIs) {
609 if (oldWindow) { 615 if (oldWindow) {
610 [notificationCenter 616 [notificationCenter
611 removeObserver:self 617 removeObserver:self
612 name:NSWindowDidChangeOcclusionStateNotification 618 name:NSWindowDidChangeOcclusionStateNotification
613 object:oldWindow]; 619 object:oldWindow];
614 } 620 }
615 if (newWindow) { 621 if (newWindow) {
616 [notificationCenter 622 [notificationCenter
617 addObserver:self 623 addObserver:self
(...skipping 13 matching lines...) Expand all
631 if (!webContents->should_normally_be_visible()) 637 if (!webContents->should_normally_be_visible())
632 webContents->WasShown(); 638 webContents->WasShown();
633 } else { 639 } else {
634 if (webContents->should_normally_be_visible()) 640 if (webContents->should_normally_be_visible())
635 webContents->WasHidden(); 641 webContents->WasHidden();
636 } 642 }
637 } 643 }
638 } 644 }
639 645
640 @end 646 @end
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698