Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 713313002: Use Binding<> instead of InterfaceImpl in ViewManagerClientImpl (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Use Binding<> instead of InterfaceImpl in ViewManagerClientImpl This way we can set up the service_ connection in the constructor instead of in a separate function. R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/38a20faf4f91db3016be479885cbdf3585118f62

Patch Set 1 #

Patch Set 2 : strong + weak bindings #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_client_factory.cc View 1 2 3 2 chunks +6 lines, -7 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 2 5 chunks +14 lines, -5 lines 1 comment Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 2 3 3 chunks +17 lines, -9 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
jamesr
6 years, 1 month ago (2014-11-13 00:30:17 UTC) #2
sky
LGTM https://codereview.chromium.org/713313002/diff/60001/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc File mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc (right): https://codereview.chromium.org/713313002/diff/60001/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc#newcode104 mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc:104: service_ = binding_.client(); move to initializer list? You'll ...
6 years, 1 month ago (2014-11-13 00:34:39 UTC) #3
jamesr
6 years, 1 month ago (2014-11-13 21:52:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
38a20faf4f91db3016be479885cbdf3585118f62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698