editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolverTest.java - Issue 713303002: Issue 21549. Fix for infinite loop in the Angular expression parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolverTest.java

Issue 713303002: Issue 21549. Fix for infinite loop in the Angular expression parser. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolver.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolverTest.java

diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolverTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolverTest.java

index 782379a3f7a8333af9f2ff6c45ae9ae5d482c220..4f8a5356abb03d8d360c1a2904c476a5ded1e14b 100644

--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolverTest.java

+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/html/angular/AngularHtmlUnitResolverTest.java

@@ -753,6 +753,12 @@ public class AngularHtmlUnitResolverTest extends AngularTest {

assertResolvedIdentifier("uppercase");

}

+ public void test_resolveExpression_withFilter_missingColon() throws Exception {

+ addMyController();

+ resolveIndex(createHtmlWithMyController("{{ctrl.field | uppercase, lowercase}}"));

+ assertErrors(indexSource, AngularCode.MISSING_FORMATTER_COLON);

+ }

public void test_resolveExpression_withFilter_notSimpleIdentifier() throws Exception {

addMyController();

resolveIndex(createHtmlWithMyController("{{ctrl.field | not.supported}}"));