Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(125)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/svg/custom/svg-image-par-none-viewbox-no-intrinsic-size.html
Issue
713263002
:
Use the viewBox when scaling <svg:image>s non-uniformly w/ pAR=none (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: The computeImageViewportSize approach.
Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/TestExpectations
LayoutTests/svg/custom/svg-image-par-none-viewbox-no-intrinsic-size.html
LayoutTests/svg/custom/svg-image-par-none-viewbox-no-intrinsic-size-expected.html
LayoutTests/svg/custom/svg-image-par-none-viewbox-percentage-size.html
LayoutTests/svg/custom/svg-image-par-none-viewbox-percentage-size-expected.html
LayoutTests/svg/custom/svg-image-par-none-zero-intrinsic-size.html
Source/core/rendering/svg/RenderSVGImage.h
Source/core/rendering/svg/RenderSVGImage.cpp
Source/platform/graphics/Image.h
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/TestExpectations
('k') |
LayoutTests/svg/custom/svg-image-par-none-viewbox-no-intrinsic-size-expected.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 <!DOCTYPE html>
1 <!DOCTYPE html>
2 <svg width="100" height="200" style="background-color: red">
2 <svg width="100" height="200" style="background-color: red">
3 <image width="100" height="200" preserveAspectRatio="none"
3 <image width="100" height="200" preserveAspectRatio="none"
4
xlink:href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg'
viewBox='0 0 100
200
'><rect width='100' height='
200
' fill='green'/></svg>"/>
4
xlink:href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg'
viewBox='0 0 100
100
'><rect width='100' height='
100
' fill='green'/></svg>"/>
5 </svg>
5 </svg>
OLD
NEW
« no previous file with comments
|
« LayoutTests/TestExpectations
('k') |
LayoutTests/svg/custom/svg-image-par-none-viewbox-no-intrinsic-size-expected.html »
('j') |
no next file with comments »
Issue 713263002: Use the viewBox when scaling <svg:image>s non-uniformly w/ pAR=none (Closed)
Created 6 years, 1 month ago by fs
Modified 6 years, 1 month ago
Reviewers: pdr., f(malita)
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 8
This is Rietveld
408576698
Chromium Code Reviews
Issue 713263002:
Use the viewBox when scaling <svg:image>s non-uniformly w/ pAR=none (Closed)
Base URL: svn://svn.chromium.org/blink/trunk