Issue 713243002: Arguments swapped in IndexError constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 713243002: Arguments swapped in IndexError constructor. (Closed)

Created:
6 years, 1 month ago by Lasse Reichstein Nielsen

Modified:
6 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Arguments swapped in IndexError constructor. Amazingly only caught by dart2js. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41660

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	sdk/lib/_internal/compiler/js_lib/native_typed_data.dart	View		4 chunks	+16 lines, -4 lines	1 comment	Download
	M	sdk/lib/core/errors.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

https://codereview.chromium.org/713243002/diff/1/sdk/lib/_internal/compiler/js_lib/native_typed_data.dart File sdk/lib/_internal/compiler/js_lib/native_typed_data.dart (right): https://codereview.chromium.org/713243002/diff/1/sdk/lib/_internal/compiler/js_lib/native_typed_data.dart#newcode151 sdk/lib/_internal/compiler/js_lib/native_typed_data.dart:151: if (index < 0 || index >= length) { ...

6 years, 1 month ago (2014-11-11 10:23:15 UTC) #3

Lasse Reichstein Nielsen

6 years, 1 month ago (2014-11-11 10:29:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r41660 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages