DevTools: do not detach views that should be hidden upon detach.

DevTools: do not detach views that should be hidden upon detach.

BUG=431761
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185229

[pfeldman, 2014-11-10 17:07:59]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2014-11-11 09:42:58]

PTAL

[pfeldman, 2014-11-11 10:14:24]

pfeldman@chromium.org changed reviewers:
+ vsevik@chromium.org

[dgozman, 2014-11-11 10:46:42]

lgtm

https://codereview.chromium.org/713053002/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/ui/SplitView.js (right):

https://codereview.chromium.org/713053002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ui/SplitView.js:196:
this._mainElement.classList.toggle("split-view-contents-first",
secondIsSidebar);
I wonder why don't we remove these classes.

[pfeldman, 2014-11-11 12:49:59]

https://codereview.chromium.org/713053002/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/ui/SplitView.js (right):

https://codereview.chromium.org/713053002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/ui/SplitView.js:196:
this._mainElement.classList.toggle("split-view-contents-first",
secondIsSidebar);
dunno.

[pfeldman, 2014-11-11 12:50:03]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-11-11 12:50:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/713053002/20001

[commit-bot: I haz the power, 2014-11-11 13:46:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-11 13:46:18]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[pfeldman, 2014-11-12 14:16:01]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-11-12 14:16:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/713053002/40001

[pfeldman, 2014-11-12 14:17:49]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2014-11-12 14:50:53]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-11-12 14:51:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/713053002/60001

[commit-bot: I haz the power, 2014-11-12 15:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-12 15:50:45]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[pfeldman, 2014-11-12 16:56:30]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-11-12 16:57:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/713053002/80001

[commit-bot: I haz the power, 2014-11-12 18:00:02]

Committed patchset #5 (id:80001) as 185229