MacViews: Get chrome/browser/ui/views/frame to compile (reland)

MacViews: Get chrome/browser/ui/views/frame to compile (reland)

Reland of https://codereview.chromium.org/697223003.

Some fixes to get this subdirectory to compile for MacViews.
An aura::Window dependency is moved from BrowserView to
BrowserCommandHandlerX11.
Hide Ash dependency from ImmersiveModeController.
Add Mac implementation of NativeBrowserFrame.

Now that we include both BrowserWindow::CreateBrowserWindow definitions
in the build, add a new build flag "mac_views_browser" to select between
Cocoa and Views browser.

BUG=425229
Committed: https://crrev.com/f15013419679b0e5860d58464f64f7e65d5c9f1e
Cr-Commit-Position: refs/heads/master@{#303958}

[Andre, 2014-11-10 21:58:31]

Patchset #3 (id:40001) has been deleted

[Andre, 2014-11-10 21:58:36]

Patchset #2 (id:20001) has been deleted

[Andre, 2014-11-10 22:09:29]

Patchset #2 (id:60001) has been deleted

[Andre, 2014-11-10 23:13:34]

Trent, Scott, PTAL.

The problem was with the set_frame_type() call in browser_frame.cc.
We can't take that line out of #if(LINUX) because on Windows it caused the frame
type to change from DEFAULT to FORCE_NATIVE.

[Andre, 2014-11-10 23:13:50]

andresantoso@chromium.org changed reviewers:
+ sky@chromium.org, tapted@chromium.org

[tapted, 2014-11-11 12:18:08]

(found this in codereview - I don't think I got an email from Rietveld)

On 2014/11/10 23:13:34, Andre wrote:
> Trent, Scott, PTAL.
> 
> The problem was with the set_frame_type() call in browser_frame.cc.
> We can't take that line out of #if(LINUX) because on Windows it caused the
frame
> type to change from DEFAULT to FORCE_NATIVE.

Ooh - subtle. At least we're getting rid of some #ifdefs.. There's some more
unguarded code in OnUseCustomChromeFrameChanged() as well (which I guess can't
be called from linux, since there's no way to change the pref, but that's also
unguarded). Probably there should be a BrowserFrameLinux like there is for
ash/win, with OnUseCustomChromeFrameChanged and its own InitBrowserFrame that
watches the pref.

OpaqueBrowserFrameView::ShouldShowWindowTitleBar() also uses UseCustomFrame()
(and #ifdefs :/), but it could perhaps be in OpaqueBrowserFrameViewLinux (which
already exists).  I think with that, non-Linux code doesn't even need to see
UseCustomFrame(). Maybe even Widget::frame_type() becomes unnecessary.. (It
seems it's invalid for it to be anything other that DEFAULT on anything that
isn't desktop linux.)

That's a bit of an orthogonal yak to shave, and should be done in isolation. I
think it's worth looking into, but I may have missed something. And I think this
reland may need to wait for a bit anyway in case the revert needs to be merged
back.

[Andre, 2014-11-11 18:09:37]

sky@ PTAL (I think the email notification didn't get sent earlier).

[sky, 2014-11-11 20:09:16]

LGTM

[Andre, 2014-11-12 22:49:36]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2014-11-12 22:51:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/713043004/80001

[commit-bot: I haz the power, 2014-11-13 00:52:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-13 00:52:49]

Failed to apply patch for build/common.gypi:
While running git apply --index -3 -p1;
  error: patch failed: build/common.gypi:1510
  Falling back to three-way merge...
  Applied patch to 'build/common.gypi' with conflicts.
  U build/common.gypi

Patch:       build/common.gypi
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
f97bf665566415d4b00747a505ce9d4976c11e67..a3afe9fdcc9a8675da16565fc3a7c8347fe9661c
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1510,6 +1510,9 @@
     'ozone_platform_ozonex%': 0,
     'ozone_platform_test%': 0,
 
+    # Whether the browser is non-native (using Views Toolkit) on Mac.
+    'mac_views_browser%': 0,
+
     'conditions': [
       ['buildtype=="Official"', {
         # Continue to embed build meta data in Official builds, basically the

[commit-bot: I haz the power, 2014-11-13 00:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[Andre, 2014-11-13 01:12:09]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2014-11-13 01:13:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/713043004/100001

[commit-bot: I haz the power, 2014-11-13 02:15:07]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2014-11-13 02:15:46]

Patchset 3 (id:??) landed as
https://crrev.com/f15013419679b0e5860d58464f64f7e65d5c9f1e
Cr-Commit-Position: refs/heads/master@{#303958}