Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 71303007: Add MSE perf Telemetry tests. (Closed)

Created:
7 years, 1 month ago by shadi
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Add MSE perf Telemetry tests. BUG=284934 NOTRY=true TEST=tools/perf/run_benchmark -v --show-stdout --browser=debug mse_cases Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236886

Patch Set 1 : #

Patch Set 2 : Add perf metrics reporting #

Total comments: 2

Patch Set 3 : cleaning cases.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+586 lines, -0 lines) Patch
M tools/perf/benchmarks/media.py View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M tools/perf/metrics/media.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/mse_cases.json View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A tools/perf/page_sets/mse_cases/startup_test.html View 1 chunk +45 lines, -0 lines 0 comments Download
A tools/perf/page_sets/mse_cases/startup_test.js View 1 1 chunk +487 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
shadi
Aaron PTAL. You can download the patch and TEST using command line in CL description.
7 years, 1 month ago (2013-11-15 22:34:08 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
7 years, 1 month ago (2013-11-16 00:06:39 UTC) #2
shadi
Perf guys, can you PTAL? This adds MSE specific metrics we need really soon.
7 years, 1 month ago (2013-11-18 20:55:38 UTC) #3
shadi
On 2013/11/18 20:55:38, shadi wrote: > Perf guys, can you PTAL? > > This adds ...
7 years, 1 month ago (2013-11-20 18:56:51 UTC) #4
tonyg
On 2013/11/20 18:56:51, shadi wrote: > On 2013/11/18 20:55:38, shadi wrote: > > Perf guys, ...
7 years, 1 month ago (2013-11-21 18:51:43 UTC) #5
dtu
lgtm other than one comment https://chromiumcodereview.appspot.com/71303007/diff/90001/tools/perf/page_sets/mse_cases.json File tools/perf/page_sets/mse_cases.json (right): https://chromiumcodereview.appspot.com/71303007/diff/90001/tools/perf/page_sets/mse_cases.json#newcode9 tools/perf/page_sets/mse_cases.json:9: "media_metrics": {"action": "test-action"} You ...
7 years, 1 month ago (2013-11-22 23:30:20 UTC) #6
shadi
Thanks! https://chromiumcodereview.appspot.com/71303007/diff/90001/tools/perf/page_sets/mse_cases.json File tools/perf/page_sets/mse_cases.json (right): https://chromiumcodereview.appspot.com/71303007/diff/90001/tools/perf/page_sets/mse_cases.json#newcode9 tools/perf/page_sets/mse_cases.json:9: "media_metrics": {"action": "test-action"} On 2013/11/22 23:30:20, dtu wrote: ...
7 years, 1 month ago (2013-11-23 00:01:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/71303007/230001
7 years, 1 month ago (2013-11-23 00:06:39 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-23 00:58:53 UTC) #9
Message was sent while issue was closed.
Change committed as 236886

Powered by Google App Engine
This is Rietveld 408576698