Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 713023002: Revert of Add remoting_host target to chromium_builder_webrtc dependencies. (Closed)

Created:
6 years, 1 month ago by Nikita (slow)
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add remoting_host target to chromium_builder_webrtc dependencies. (patchset #1 id:1 of https://codereview.chromium.org/706753003/) Reason for revert: Breaks Linux ChromiumOS Ozone Builder http://goo.gl/oHjcNA ________ running '/usr/bin/python src/build/gyp_chromium' in '/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build' Updating projects from gyp files... Traceback (most recent call last): File "src/build/gyp_chromium", line 318, in <module> gyp_rc = gyp.main(args) File "/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/tools/gyp/pylib/gyp/__init__.py", line 525, in main return gyp_main(args) File "/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/tools/gyp/pylib/gyp/__init__.py", line 501, in gyp_main params, options.check, options.circular_check) File "/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/tools/gyp/pylib/gyp/__init__.py", line 129, in Load params['parallel'], params['root_targets']) File "/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/tools/gyp/pylib/gyp/input.py", line 2745, in Load RemoveLinkDependenciesFromNoneTargets(targets) File "/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/tools/gyp/pylib/gyp/input.py", line 1489, in RemoveLinkDependenciesFromNoneTargets if targets[t].get('variables', {}).get('link_dependency', 0): KeyError: '/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/remoting/remoting.gyp:remoting_host#target' Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /b/build/slave/Linux_ChromiumOS_Ozone_Builder/build Hook '/usr/bin/python src/build/gyp_chromium' took 14.48 secs Original issue's description: > Add remoting_host target to chromium_builder_webrtc dependencies. > > This will make it possible for us to catch compile failures in the > remoting_host component when rolling the WebRTC and libjingle revisions > in Chromium DEPS using the bots in > http://build.chromium.org/p/chromium.webrtc.fyi/waterfall > > Committed: https://crrev.com/32e1bf6e3fcc38662eb1dd1b0a1a2739a95992ec > Cr-Commit-Position: refs/heads/master@{#303436} TBR=perkj@chromium.org,kjellander@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9bc77cc968237f28405aa16a1d8f50a9e39760a9 Cr-Commit-Position: refs/heads/master@{#303453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nikita (slow)
Created Revert of Add remoting_host target to chromium_builder_webrtc dependencies.
6 years, 1 month ago (2014-11-10 13:11:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713023002/1
6 years, 1 month ago (2014-11-10 13:12:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-10 13:13:20 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9bc77cc968237f28405aa16a1d8f50a9e39760a9 Cr-Commit-Position: refs/heads/master@{#303453}
6 years, 1 month ago (2014-11-10 13:13:55 UTC) #4
kjellander_chromium
6 years, 1 month ago (2014-11-11 08:28:54 UTC) #5
Message was sent while issue was closed.
On 2014/11/10 13:13:55, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/9bc77cc968237f28405aa16a1d8f50a9e39760a9
> Cr-Commit-Position: refs/heads/master@{#303453}

Thanks for reverting. I wasn't aware of the different configs so I'll make sure
to run the Ozone trybot for the re-land in
https://codereview.chromium.org/711023002/

Powered by Google App Engine
This is Rietveld 408576698