Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 713013005: Deflake xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
Nate Chapin
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Deflake xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html This test was flaky because the iframe sent a postMessage to the parent frame in its load handler. However, the parent frame may or may not have run its load handler. If the parent frame's load handler hadn't run yet, then there would be no handler for a postMessage. To prevent this race, don't load the iframe until the parent frame is fully initialized. BUG=409579 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
6 years, 1 month ago (2014-11-11 00:31:13 UTC) #2
Nate Chapin
lgtm
6 years, 1 month ago (2014-11-11 00:33:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713013005/1
6 years, 1 month ago (2014-11-11 00:35:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/35709)
6 years, 1 month ago (2014-11-11 02:43:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713013005/1
6 years, 1 month ago (2014-11-11 02:51:02 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 03:52:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185097

Powered by Google App Engine
This is Rietveld 408576698