Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 712993007: Fixing parameter names in AudioDirectiveHandler (Closed)

Created:
6 years, 1 month ago by Charlie
Modified:
6 years, 1 month ago
Reviewers:
rkc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing parameter names in AudioDirectiveHandler. These TTLs have their units built in. Thus it's redundant and confusing to add _ms on the end. Committed: https://crrev.com/c90da078f23d29eb450c7a94824d6f658fbb3cee Cr-Commit-Position: refs/heads/master@{#303556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/copresence/handlers/audio/audio_directive_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/copresence/handlers/audio/audio_directive_handler_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie
6 years, 1 month ago (2014-11-10 23:00:44 UTC) #2
rkc
lgtm
6 years, 1 month ago (2014-11-11 00:02:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712993007/1
6 years, 1 month ago (2014-11-11 00:04:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 01:01:14 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 01:01:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c90da078f23d29eb450c7a94824d6f658fbb3cee
Cr-Commit-Position: refs/heads/master@{#303556}

Powered by Google App Engine
This is Rietveld 408576698