Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 712983002: Exposing correct state for summary element depending on open attribute. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni, aboxhall
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Exposing correct state for summary element depending on open attribute. Mac: In the Mac accessibility API on the summary element (AXDisclosureTriangle), set AXExpanded property to NO. When the details element content is shown, on the summary element (AXDisclosureTriangle), set theAXExpanded property to YES. Win: In the IA2 accessibility API on the summary element (ROLE_SYSTEM_PUSHBUTTON), set STATE_SYSTEM_COLLAPSED. When the details element content is shown, on the summary element (ROLE_SYSTEM_PUSHBUTTON), set STATE_SYSTEM_EXPANDED. How hidden nd show states is reflected for details element? The hidden and shown states of the details element content is reflected by the absence or presence of the open attribute. This is in accordance with the spec http://rawgit.com/w3c/aria/master/html-aam/html-aam.html#summary-and-details-elements BUG=282016 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
shreeramk
Please review. Thanks!
6 years, 1 month ago (2014-11-10 12:06:45 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-10 17:09:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712983002/1
6 years, 1 month ago (2014-11-10 17:09:40 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 17:50:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185050

Powered by Google App Engine
This is Rietveld 408576698