harmony-scoping: Implement StoreIC handler for stores to global contexts.

harmony-scoping: Implement StoreIC handler for stores to global contexts.

R=ishell@chromium.org, adamk@chromium.org, rossberg@chromium.org, verwaest@chromium.org
BUG=v8:2198
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=25264

[Dmitry Lomov (no reviews), 2014-11-10 10:36:21]

This is done but depends on https://codereview.chromium.org/696783005/
(LoadICs).
Take a look at your leisure, after that lands, I'll re-upload for proper review

[Dmitry Lomov (no reviews), 2014-11-11 11:47:38]

dslomov@chromium.org changed reviewers:
+ ishell@chromium.org
- verwaest@chromium.org

[Dmitry Lomov (no reviews), 2014-11-11 11:47:39]

This is now rebased and ready for review

[rossberg, 2014-11-11 12:37:40]

Looks good to me, but perhaps somebody with more IC expertise should also have a
look.

https://codereview.chromium.org/712973002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/712973002/diff/20001/src/code-stubs.h#newcode...
src/code-stubs.h:2062: virtual Code::Kind kind() const { return Code::LOAD_IC; }
OVERRIDE?

https://codereview.chromium.org/712973002/diff/20001/src/code-stubs.h#newcode...
src/code-stubs.h:2075: virtual Code::Kind kind() const { return Code::STORE_IC;
}
OVERRIDE?

[Igor Sheludko, 2014-11-11 14:17:07]

lgtm with a nit:

https://codereview.chromium.org/712973002/diff/20001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):

https://codereview.chromium.org/712973002/diff/20001/src/code-stubs-hydrogen....
src/code-stubs-hydrogen.cc:549: HObjectAccess::ForGlobalContext(context_index));
I think it is worth adding BuildGetGlobalContext() method and use it here and in
LoadGlobalContextFieldStub.

[Dmitry Lomov (no reviews), 2014-11-11 15:15:25]

Comments addressed, landing

https://codereview.chromium.org/712973002/diff/20001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):

https://codereview.chromium.org/712973002/diff/20001/src/code-stubs-hydrogen....
src/code-stubs-hydrogen.cc:549: HObjectAccess::ForGlobalContext(context_index));
On 2014/11/11 14:17:06, Igor Sheludko wrote:
> I think it is worth adding BuildGetGlobalContext() method and use it here and
in
> LoadGlobalContextFieldStub.

Done.

https://codereview.chromium.org/712973002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/712973002/diff/20001/src/code-stubs.h#newcode...
src/code-stubs.h:2062: virtual Code::Kind kind() const { return Code::LOAD_IC; }
On 2014/11/11 12:37:39, rossberg wrote:
> OVERRIDE?

Done.

https://codereview.chromium.org/712973002/diff/20001/src/code-stubs.h#newcode...
src/code-stubs.h:2075: virtual Code::Kind kind() const { return Code::STORE_IC;
}
On 2014/11/11 12:37:39, rossberg wrote:
> OVERRIDE?

Done.

[Dmitry Lomov (no reviews), 2014-11-11 15:15:51]

Committed patchset #3 (id:40001) manually as 25264 (presubmit successful).