Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 712943002: MapCache simplification. It is now a FixedArray that maps number of properties to a WeakCell with... (Closed)

Created:
6 years, 1 month ago by Igor Sheludko
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MapCache simplification. It is now a FixedArray that maps number of properties to a WeakCell with a Map. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25253

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -218 lines) Patch
M src/contexts.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 2 chunks +4 lines, -11 lines 0 comments Download
M src/factory.cc View 3 chunks +31 lines, -24 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +0 lines, -57 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -38 lines 0 comments Download
M src/objects.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/runtime/runtime-literals.cc View 2 chunks +5 lines, -37 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +26 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Igor Sheludko
PTAL
6 years, 1 month ago (2014-11-10 13:42:33 UTC) #5
Igor Sheludko
Addressed offline comments.
6 years, 1 month ago (2014-11-10 15:21:01 UTC) #8
Toon Verwaest
lgtm, nice simplification!
6 years, 1 month ago (2014-11-10 15:38:09 UTC) #9
Igor Sheludko
6 years, 1 month ago (2014-11-10 18:04:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:90001) manually as 25253 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698