Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 712833002: Undoing revert, cl is not the cause of gcm crash on canary. (Closed)

Created:
6 years, 1 month ago by matthewyuan
Modified:
6 years, 1 month ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Project:
chromium
Visibility:
Public.

Description

Undoing revert, cl is not the cause of gcm crash on canary. Adding GCM support to the copresence component. The Copresence server can push directives (and messages, though they are not yet handled) over GCM. BUG=424253, 425681 Review URL: https://codereview.chromium.org/710513004 Cr-Commit-Position: refs/heads/master@{#303342} (cherry picked from commit 19b4f6371c68fe1627c2b75ca5ec8a4061796e58) Committed: https://chromium.googlesource.com/chromium/src/+/6653d47b2bfd58c5e85bb8a4c031446843e17dff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -75 lines) Patch
M chrome/browser/extensions/api/copresence/copresence_api.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/copresence/copresence_api.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/copresence.gypi View 3 chunks +11 lines, -0 lines 0 comments Download
M components/copresence/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/copresence/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/copresence/copresence_manager_impl.h View 2 chunks +6 lines, -4 lines 0 comments Download
M components/copresence/copresence_manager_impl.cc View 2 chunks +10 lines, -3 lines 0 comments Download
A components/copresence/handlers/gcm_handler.h View 1 chunk +78 lines, -0 lines 0 comments Download
A components/copresence/handlers/gcm_handler.cc View 1 chunk +155 lines, -0 lines 0 comments Download
A components/copresence/handlers/gcm_handler_unittest.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M components/copresence/proto/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/copresence/proto/data.proto View 1 chunk +4 lines, -0 lines 0 comments Download
A components/copresence/proto/push_message.proto View 1 chunk +20 lines, -0 lines 0 comments Download
M components/copresence/public/copresence_delegate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M components/copresence/rpc/rpc_handler.h View 5 chunks +10 lines, -2 lines 0 comments Download
M components/copresence/rpc/rpc_handler.cc View 12 chunks +91 lines, -26 lines 0 comments Download
M components/copresence/rpc/rpc_handler_unittest.cc View 5 chunks +8 lines, -40 lines 0 comments Download
A components/copresence/test/fake_directive_handler.h View 1 chunk +49 lines, -0 lines 0 comments Download
A components/copresence/test/fake_directive_handler.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
matthewyuan
6 years, 1 month ago (2014-11-08 23:40:07 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6653d47b2bfd58c5e85bb8a4c031446843e17dff.

Powered by Google App Engine
This is Rietveld 408576698