Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 712793003: Revert of Fixing all of problems found by vc++ /analyze in GCM code (Closed)

Created:
6 years, 1 month ago by matthewyuan
Modified:
6 years, 1 month ago
CC:
chromium-reviews, zea+watch_chromium.org, brucedawson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixing all of problems found by vc++ /analyze in GCM code (patchset #1 id:1 of https://codereview.chromium.org/713573003/) Reason for revert: Reverting since it's causing a crash on canary. Original issue's description: > Fixing all of problems found by vc++ /analyze in GCM code > > There was only a minor (harmless) case of variable shadowing. > > BUG=427616 > R=zea@chromium.org > > Committed: https://crrev.com/3e021981ccc2be8de7443ff1a18439551b22ea75 > Cr-Commit-Position: refs/heads/master@{#303338} TBR=zea@chromium.org,brucedawson@chromium.org,fgorski@chromium.org NOTREECHECKS=true NOTRY=true BUG=427616 Committed: https://crrev.com/bca70e90f5c0de7b071d277e0d7886e1e0823572 Cr-Commit-Position: refs/heads/master@{#303396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M google_apis/gcm/engine/gcm_store_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
matthewyuan
Created Revert of Fixing all of problems found by vc++ /analyze in GCM code
6 years, 1 month ago (2014-11-08 22:27:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712793003/1
6 years, 1 month ago (2014-11-08 22:28:27 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-08 22:28:29 UTC) #4
kareng
On 2014/11/08 22:28:29, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 1 month ago (2014-11-08 22:34:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712793003/1
6 years, 1 month ago (2014-11-08 22:35:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-08 22:36:23 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 22:36:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bca70e90f5c0de7b071d277e0d7886e1e0823572
Cr-Commit-Position: refs/heads/master@{#303396}

Powered by Google App Engine
This is Rietveld 408576698