Issue 712683002: Revert of SkDrawCommand scrubbing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 712683002: Revert of SkDrawCommand scrubbing (Closed)

Created:
6 years, 1 month ago by f(malita)

Modified:
6 years, 1 month ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of SkDrawCommand scrubbing (patchset #2 id:20001 of https://codereview.chromium.org/706363002/) Reason for revert: Canary borkage. Original issue's description: > SkDrawCommand scrubbing > > Remove unused ctor, constify, etc. > > R=robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/9063ddd511f8e0d8c7454950cbc56e273678bf60

Patch Set 1 #

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -95 lines)			Patch
M	debugger/QT/SkDebuggerGUI.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	debugger/SkDebugger.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/debugger/SkDrawCommand.h	View	42 chunks	+54 lines, -52 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.cpp	View	38 chunks	+44 lines, -39 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712683002/1

6 years, 1 month ago (2014-11-07 20:26:36 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9063ddd511f8e0d8c7454950cbc56e273678bf60

6 years, 1 month ago (2014-11-07 20:26:49 UTC) #3

f(malita)

6 years, 1 month ago (2014-11-09 00:17:59 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/708333002/ by fmalita@chromium.org.

The reason for reverting is: Chromium clients updated, this should be
canary-proof now..

Expand Messages | Collapse Messages