Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 712653002: Fix RemoteFrame detachment to signal its client. (Closed)

Created:
6 years, 1 month ago by kenrb
Modified:
6 years, 1 month ago
Reviewers:
Nate Chapin, dcheng
CC:
blink-reviews, dglazkov+blink, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix RemoteFrame detachment to signal its client. We were seeing crashes in checkFrameCountConsistency() because during RemoteFrame detachment the client was not getting signalled to modify the frame tree, resulting in inconsistent state. This CL corrects that problem. BUG=430972 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M Source/web/RemoteFrameClientImpl.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M public/web/WebRemoteFrameClient.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kenrb
Nate: PTAL?
6 years, 1 month ago (2014-11-07 18:43:18 UTC) #2
dcheng
lgtm
6 years, 1 month ago (2014-11-07 18:46:38 UTC) #4
Nate Chapin
lgtm
6 years, 1 month ago (2014-11-07 19:40:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712653002/1
6 years, 1 month ago (2014-11-07 19:41:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 184987
6 years, 1 month ago (2014-11-07 19:49:57 UTC) #8
raymes
6 years, 1 month ago (2014-11-10 01:16:07 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/699053004/ by raymes@chromium.org.

The reason for reverting is: Speculative revert to attempt to fix
https://code.google.com/p/chromium/issues/detail?id=431608.

Powered by Google App Engine
This is Rietveld 408576698