Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 712613002: add patch and clicktracking to lua (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add patch and clicktracking to lua BUG=skia: Committed: https://skia.googlesource.com/skia/+/7a72c6702da9e1f6fb536efe844db23f77535a19

Patch Set 1 #

Total comments: 11

Patch Set 2 : remove sloppy slides2.lua for now #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -27 lines) Patch
M samplecode/SampleLua.cpp View 2 3 chunks +33 lines, -2 lines 0 comments Download
M src/utils/SkLua.cpp View 1 12 chunks +111 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
reed1
6 years, 1 month ago (2014-11-07 15:46:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712613002/1
6 years, 1 month ago (2014-11-07 15:47:01 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-07 15:47:03 UTC) #5
robertphillips
lgtm + nits https://codereview.chromium.org/712613002/diff/1/resources/slides2.lua File resources/slides2.lua (right): https://codereview.chromium.org/712613002/diff/1/resources/slides2.lua#newcode319 resources/slides2.lua:319: cubics = {} // bottom https://codereview.chromium.org/712613002/diff/1/resources/slides2.lua#newcode322 ...
6 years, 1 month ago (2014-11-07 18:02:54 UTC) #7
reed1
https://codereview.chromium.org/712613002/diff/1/src/utils/SkLua.cpp File src/utils/SkLua.cpp (right): https://codereview.chromium.org/712613002/diff/1/src/utils/SkLua.cpp#newcode541 src/utils/SkLua.cpp:541: On 2014/11/07 18:02:54, robertphillips wrote: > needed ? Done.
6 years, 1 month ago (2014-11-07 18:12:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712613002/40001
6 years, 1 month ago (2014-11-07 18:14:15 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 18:23:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7a72c6702da9e1f6fb536efe844db23f77535a19

Powered by Google App Engine
This is Rietveld 408576698