Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: media/mojo/services/media_type_converters_unittest.cc

Issue 712593003: Move key frame flag from StreamParserBuffer to DecoderBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/media_type_converters.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/media_type_converters_unittest.cc
diff --git a/media/mojo/services/media_type_converters_unittest.cc b/media/mojo/services/media_type_converters_unittest.cc
index 1bf9b854e88b093fd20d0ff711cdb4c14df58e4f..908714a6da0cab80580d928baa8e24191c35abf1 100644
--- a/media/mojo/services/media_type_converters_unittest.cc
+++ b/media/mojo/services/media_type_converters_unittest.cc
@@ -25,6 +25,7 @@ TEST(MediaTypeConvertersTest, ConvertDecoderBuffer_Normal) {
reinterpret_cast<const uint8*>(&kSideData), kSideDataSize));
buffer->set_timestamp(base::TimeDelta::FromMilliseconds(123));
buffer->set_duration(base::TimeDelta::FromMilliseconds(456));
+ buffer->set_is_key_frame(true);
buffer->set_splice_timestamp(base::TimeDelta::FromMilliseconds(200));
buffer->set_discard_padding(media::DecoderBuffer::DiscardPadding(
base::TimeDelta::FromMilliseconds(5),
@@ -41,8 +42,16 @@ TEST(MediaTypeConvertersTest, ConvertDecoderBuffer_Normal) {
EXPECT_EQ(0, memcmp(result->side_data(), kSideData, kSideDataSize));
EXPECT_EQ(buffer->timestamp(), result->timestamp());
EXPECT_EQ(buffer->duration(), result->duration());
+ EXPECT_EQ(buffer->is_key_frame(), result->is_key_frame());
EXPECT_EQ(buffer->splice_timestamp(), result->splice_timestamp());
EXPECT_EQ(buffer->discard_padding(), result->discard_padding());
+
+ // Verify a false |is_key_frame| round-trips.
+ buffer->set_is_key_frame(false);
+ MediaDecoderBufferPtr ptr2(MediaDecoderBuffer::From(buffer));
+ scoped_refptr<DecoderBuffer> result2(ptr2.To<scoped_refptr<DecoderBuffer>>());
+ EXPECT_EQ(0, memcmp(result2->data(), kData, kDataSize));
+ EXPECT_EQ(buffer->is_key_frame(), result2->is_key_frame());
}
TEST(MediaTypeConvertersTest, ConvertDecoderBuffer_EOS) {
« no previous file with comments | « media/mojo/services/media_type_converters.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698