Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Unified Diff: media/base/decoder_buffer_unittest.cc

Issue 712593003: Move key frame flag from StreamParserBuffer to DecoderBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/decoder_buffer.cc ('k') | media/base/decryptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/decoder_buffer_unittest.cc
diff --git a/media/base/decoder_buffer_unittest.cc b/media/base/decoder_buffer_unittest.cc
index c5a03b78450e0f4f7ab9eee029c6acb0f2619dee..20cc1fb3b3212c3f02ec18862bf093bcf5ae2a37 100644
--- a/media/base/decoder_buffer_unittest.cc
+++ b/media/base/decoder_buffer_unittest.cc
@@ -13,6 +13,7 @@ TEST(DecoderBufferTest, Constructors) {
EXPECT_TRUE(buffer->data());
EXPECT_EQ(0, buffer->data_size());
EXPECT_FALSE(buffer->end_of_stream());
+ EXPECT_FALSE(buffer->is_key_frame());
const int kTestSize = 10;
scoped_refptr<DecoderBuffer> buffer3(new DecoderBuffer(kTestSize));
@@ -28,6 +29,7 @@ TEST(DecoderBufferTest, CreateEOSBuffer) {
TEST(DecoderBufferTest, CopyFrom) {
const uint8 kData[] = "hello";
const int kDataSize = arraysize(kData);
+
scoped_refptr<DecoderBuffer> buffer2(DecoderBuffer::CopyFrom(
reinterpret_cast<const uint8*>(&kData), kDataSize));
ASSERT_TRUE(buffer2.get());
@@ -35,6 +37,8 @@ TEST(DecoderBufferTest, CopyFrom) {
EXPECT_EQ(buffer2->data_size(), kDataSize);
EXPECT_EQ(0, memcmp(buffer2->data(), kData, kDataSize));
EXPECT_FALSE(buffer2->end_of_stream());
+ EXPECT_FALSE(buffer2->is_key_frame());
+
scoped_refptr<DecoderBuffer> buffer3(DecoderBuffer::CopyFrom(
reinterpret_cast<const uint8*>(&kData), kDataSize,
reinterpret_cast<const uint8*>(&kData), kDataSize));
@@ -46,6 +50,7 @@ TEST(DecoderBufferTest, CopyFrom) {
EXPECT_EQ(buffer3->side_data_size(), kDataSize);
EXPECT_EQ(0, memcmp(buffer3->side_data(), kData, kDataSize));
EXPECT_FALSE(buffer3->end_of_stream());
+ EXPECT_FALSE(buffer3->is_key_frame());
}
#if !defined(OS_ANDROID)
@@ -72,6 +77,8 @@ TEST(DecoderBufferTest, PaddingAlignment) {
EXPECT_EQ(0u, reinterpret_cast<uintptr_t>(
buffer2->data()) & (DecoderBuffer::kAlignmentSize - 1));
+
+ EXPECT_FALSE(buffer2->is_key_frame());
}
#endif
@@ -97,4 +104,15 @@ TEST(DecoderBufferTest, GetDecryptConfig) {
EXPECT_FALSE(buffer->decrypt_config());
}
+TEST(DecoderBufferTest, IsKeyFrame) {
+ scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(0));
+ EXPECT_FALSE(buffer->is_key_frame());
+
+ buffer->set_is_key_frame(false);
+ EXPECT_FALSE(buffer->is_key_frame());
+
+ buffer->set_is_key_frame(true);
+ EXPECT_TRUE(buffer->is_key_frame());
+}
+
} // namespace media
« no previous file with comments | « media/base/decoder_buffer.cc ('k') | media/base/decryptor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698