Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: media/base/decoder_buffer_unittest.cc

Issue 712593003: Move key frame flag from StreamParserBuffer to DecoderBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address PS1 comments, update mojo type converter Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/string_util.h" 5 #include "base/strings/string_util.h"
6 #include "media/base/decoder_buffer.h" 6 #include "media/base/decoder_buffer.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace media { 9 namespace media {
10 10
11 TEST(DecoderBufferTest, Constructors) { 11 TEST(DecoderBufferTest, Constructors) {
12 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(0)); 12 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(0));
13 EXPECT_TRUE(buffer->data()); 13 EXPECT_TRUE(buffer->data());
14 EXPECT_EQ(0, buffer->data_size()); 14 EXPECT_EQ(0, buffer->data_size());
15 EXPECT_FALSE(buffer->end_of_stream()); 15 EXPECT_FALSE(buffer->end_of_stream());
16 EXPECT_FALSE(buffer->is_key_frame());
16 17
17 const int kTestSize = 10; 18 const int kTestSize = 10;
18 scoped_refptr<DecoderBuffer> buffer3(new DecoderBuffer(kTestSize)); 19 scoped_refptr<DecoderBuffer> buffer3(new DecoderBuffer(kTestSize));
19 ASSERT_TRUE(buffer3.get()); 20 ASSERT_TRUE(buffer3.get());
20 EXPECT_EQ(kTestSize, buffer3->data_size()); 21 EXPECT_EQ(kTestSize, buffer3->data_size());
21 } 22 }
22 23
23 TEST(DecoderBufferTest, CreateEOSBuffer) { 24 TEST(DecoderBufferTest, CreateEOSBuffer) {
24 scoped_refptr<DecoderBuffer> buffer(DecoderBuffer::CreateEOSBuffer()); 25 scoped_refptr<DecoderBuffer> buffer(DecoderBuffer::CreateEOSBuffer());
25 EXPECT_TRUE(buffer->end_of_stream()); 26 EXPECT_TRUE(buffer->end_of_stream());
26 } 27 }
27 28
28 TEST(DecoderBufferTest, CopyFrom) { 29 TEST(DecoderBufferTest, CopyFrom) {
29 const uint8 kData[] = "hello"; 30 const uint8 kData[] = "hello";
30 const int kDataSize = arraysize(kData); 31 const int kDataSize = arraysize(kData);
32
31 scoped_refptr<DecoderBuffer> buffer2(DecoderBuffer::CopyFrom( 33 scoped_refptr<DecoderBuffer> buffer2(DecoderBuffer::CopyFrom(
32 reinterpret_cast<const uint8*>(&kData), kDataSize)); 34 reinterpret_cast<const uint8*>(&kData), kDataSize));
33 ASSERT_TRUE(buffer2.get()); 35 ASSERT_TRUE(buffer2.get());
34 EXPECT_NE(kData, buffer2->data()); 36 EXPECT_NE(kData, buffer2->data());
35 EXPECT_EQ(buffer2->data_size(), kDataSize); 37 EXPECT_EQ(buffer2->data_size(), kDataSize);
36 EXPECT_EQ(0, memcmp(buffer2->data(), kData, kDataSize)); 38 EXPECT_EQ(0, memcmp(buffer2->data(), kData, kDataSize));
37 EXPECT_FALSE(buffer2->end_of_stream()); 39 EXPECT_FALSE(buffer2->end_of_stream());
40 EXPECT_FALSE(buffer2->is_key_frame());
41
38 scoped_refptr<DecoderBuffer> buffer3(DecoderBuffer::CopyFrom( 42 scoped_refptr<DecoderBuffer> buffer3(DecoderBuffer::CopyFrom(
39 reinterpret_cast<const uint8*>(&kData), kDataSize, 43 reinterpret_cast<const uint8*>(&kData), kDataSize,
40 reinterpret_cast<const uint8*>(&kData), kDataSize)); 44 reinterpret_cast<const uint8*>(&kData), kDataSize));
41 ASSERT_TRUE(buffer3.get()); 45 ASSERT_TRUE(buffer3.get());
42 EXPECT_NE(kData, buffer3->data()); 46 EXPECT_NE(kData, buffer3->data());
43 EXPECT_EQ(buffer3->data_size(), kDataSize); 47 EXPECT_EQ(buffer3->data_size(), kDataSize);
44 EXPECT_EQ(0, memcmp(buffer3->data(), kData, kDataSize)); 48 EXPECT_EQ(0, memcmp(buffer3->data(), kData, kDataSize));
45 EXPECT_NE(kData, buffer3->side_data()); 49 EXPECT_NE(kData, buffer3->side_data());
46 EXPECT_EQ(buffer3->side_data_size(), kDataSize); 50 EXPECT_EQ(buffer3->side_data_size(), kDataSize);
47 EXPECT_EQ(0, memcmp(buffer3->side_data(), kData, kDataSize)); 51 EXPECT_EQ(0, memcmp(buffer3->side_data(), kData, kDataSize));
48 EXPECT_FALSE(buffer3->end_of_stream()); 52 EXPECT_FALSE(buffer3->end_of_stream());
53 EXPECT_FALSE(buffer3->is_key_frame());
49 } 54 }
50 55
51 #if !defined(OS_ANDROID) 56 #if !defined(OS_ANDROID)
52 TEST(DecoderBufferTest, PaddingAlignment) { 57 TEST(DecoderBufferTest, PaddingAlignment) {
53 const uint8 kData[] = "hello"; 58 const uint8 kData[] = "hello";
54 const int kDataSize = arraysize(kData); 59 const int kDataSize = arraysize(kData);
55 scoped_refptr<DecoderBuffer> buffer2(DecoderBuffer::CopyFrom( 60 scoped_refptr<DecoderBuffer> buffer2(DecoderBuffer::CopyFrom(
56 reinterpret_cast<const uint8*>(&kData), kDataSize)); 61 reinterpret_cast<const uint8*>(&kData), kDataSize));
57 ASSERT_TRUE(buffer2.get()); 62 ASSERT_TRUE(buffer2.get());
58 63
59 // Padding data should always be zeroed. 64 // Padding data should always be zeroed.
60 for(int i = 0; i < DecoderBuffer::kPaddingSize; i++) 65 for(int i = 0; i < DecoderBuffer::kPaddingSize; i++)
61 EXPECT_EQ((buffer2->data() + kDataSize)[i], 0); 66 EXPECT_EQ((buffer2->data() + kDataSize)[i], 0);
62 67
63 // If the data is padded correctly we should be able to read and write past 68 // If the data is padded correctly we should be able to read and write past
64 // the end of the data by DecoderBuffer::kPaddingSize bytes without crashing 69 // the end of the data by DecoderBuffer::kPaddingSize bytes without crashing
65 // or Valgrind/ASAN throwing errors. 70 // or Valgrind/ASAN throwing errors.
66 const uint8 kFillChar = 0xFF; 71 const uint8 kFillChar = 0xFF;
67 memset( 72 memset(
68 buffer2->writable_data() + kDataSize, kFillChar, 73 buffer2->writable_data() + kDataSize, kFillChar,
69 DecoderBuffer::kPaddingSize); 74 DecoderBuffer::kPaddingSize);
70 for(int i = 0; i < DecoderBuffer::kPaddingSize; i++) 75 for(int i = 0; i < DecoderBuffer::kPaddingSize; i++)
71 EXPECT_EQ((buffer2->data() + kDataSize)[i], kFillChar); 76 EXPECT_EQ((buffer2->data() + kDataSize)[i], kFillChar);
72 77
73 EXPECT_EQ(0u, reinterpret_cast<uintptr_t>( 78 EXPECT_EQ(0u, reinterpret_cast<uintptr_t>(
74 buffer2->data()) & (DecoderBuffer::kAlignmentSize - 1)); 79 buffer2->data()) & (DecoderBuffer::kAlignmentSize - 1));
80
81 EXPECT_FALSE(buffer2->is_key_frame());
75 } 82 }
76 #endif 83 #endif
77 84
78 TEST(DecoderBufferTest, ReadingWriting) { 85 TEST(DecoderBufferTest, ReadingWriting) {
79 const char kData[] = "hello"; 86 const char kData[] = "hello";
80 const int kDataSize = arraysize(kData); 87 const int kDataSize = arraysize(kData);
81 88
82 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(kDataSize)); 89 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(kDataSize));
83 ASSERT_TRUE(buffer.get()); 90 ASSERT_TRUE(buffer.get());
84 91
85 uint8* data = buffer->writable_data(); 92 uint8* data = buffer->writable_data();
86 ASSERT_TRUE(data); 93 ASSERT_TRUE(data);
87 ASSERT_EQ(kDataSize, buffer->data_size()); 94 ASSERT_EQ(kDataSize, buffer->data_size());
88 memcpy(data, kData, kDataSize); 95 memcpy(data, kData, kDataSize);
89 const uint8* read_only_data = buffer->data(); 96 const uint8* read_only_data = buffer->data();
90 ASSERT_EQ(data, read_only_data); 97 ASSERT_EQ(data, read_only_data);
91 ASSERT_EQ(0, memcmp(read_only_data, kData, kDataSize)); 98 ASSERT_EQ(0, memcmp(read_only_data, kData, kDataSize));
92 EXPECT_FALSE(buffer->end_of_stream()); 99 EXPECT_FALSE(buffer->end_of_stream());
93 } 100 }
94 101
95 TEST(DecoderBufferTest, GetDecryptConfig) { 102 TEST(DecoderBufferTest, GetDecryptConfig) {
96 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(0)); 103 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(0));
97 EXPECT_FALSE(buffer->decrypt_config()); 104 EXPECT_FALSE(buffer->decrypt_config());
98 } 105 }
99 106
107 TEST(DecoderBufferTest, IsKeyFrame) {
108 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(0));
109 EXPECT_FALSE(buffer->is_key_frame());
110
111 buffer->set_is_key_frame(false);
112 EXPECT_FALSE(buffer->is_key_frame());
113
114 buffer->set_is_key_frame(true);
115 EXPECT_TRUE(buffer->is_key_frame());
116 }
117
100 } // namespace media 118 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698