Move key frame flag from StreamParserBuffer to DecoderBuffer

media/base/decryptor.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_DECRYPTOR_H_
 #define MEDIA_BASE_DECRYPTOR_H_
 
 #include <list>
 
 #include "base/basictypes.h"
@@ skipping 51 matching lines @@
   //
   // First parameter: The status of the decryption operation.
   // - Set to kSuccess if the encrypted buffer is successfully decrypted and
   //   the decrypted buffer is ready to be read.
   // - Set to kNoKey if no decryption key is available to decrypt the encrypted
   //   buffer. In this case the decrypted buffer must be NULL.
   // - Set to kError if unexpected error has occurred. In this case the
   //   decrypted buffer must be NULL.
   // - This parameter should not be set to kNeedMoreData.
   // Second parameter: The decrypted buffer.
+  // - The buffer's keyframe flag is always set to false. The callback handler
+  //   is responsible for setting this flag true as appropriate.

[xhwang, 2014/11/10 20:14:12]

How about: Only |data|, |data_size| and |timestamp| are set in the returned
DecoderBuffer. The callback handler is responsible for setting other fields as
appropriate.

[wolenetz, 2014/11/11 22:39:41]

Done.

   typedef base::Callback<void(Status,
                               const scoped_refptr<DecoderBuffer>&)> DecryptCB;
 
   // Decrypts the |encrypted| buffer. The decrypt status and decrypted buffer
   // are returned via the provided callback |decrypt_cb|. The |encrypted| buffer
   // must not be NULL.
   // Decrypt() should not be called until any previous DecryptCB of the same
   // |stream_type| has completed. Thus, only one DecryptCB may be pending at
   // a time for a given |stream_type|.
   virtual void Decrypt(StreamType stream_type,
@@ skipping 93 matching lines @@
 // notification. When the decryptor is ready, notification will be sent
 // through the provided callback.
 // Calling this callback with a null callback cancels previously registered
 // decryptor ready notification. Any previously provided callback will be
 // fired immediately with NULL.
 typedef base::Callback<void(const DecryptorReadyCB&)> SetDecryptorReadyCB;
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_DECRYPTOR_H_