DevTools: DevTools opened for an old version of chrome or webview can't record cpu/heap profile.

DevTools: DevTools opened for an old version of chrome or webview can't record cpu/heap profile.

The reason of that is a difference in URL for TempStorageSharedWorker between the host and the device front-ends
If DevTools window for a host page was opened before DevTools window for a device then the second DevTools
window will fail to run the shared worker and vice versa.

BUG=430794
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185012

[loislo, 2014-11-07 14:43:18]

loislo@chromium.org changed reviewers:
+ alph@chromium.org, yurys@chromium.org

[yurys, 2014-11-07 14:50:07]

https://codereview.chromium.org/712593002/diff/1/Source/devtools/front_end/bi...
File Source/devtools/front_end/bindings/TempFile.js (right):

https://codereview.chromium.org/712593002/diff/1/Source/devtools/front_end/bi...
Source/devtools/front_end/bindings/TempFile.js:373: if (e.name !==
"URLMismatchError")
Invert the condition?

[loislo, 2014-11-07 14:51:46]

https://codereview.chromium.org/712593002/diff/1/Source/devtools/front_end/bi...
File Source/devtools/front_end/bindings/TempFile.js (right):

https://codereview.chromium.org/712593002/diff/1/Source/devtools/front_end/bi...
Source/devtools/front_end/bindings/TempFile.js:373: if (e.name !==
"URLMismatchError")
On 2014/11/07 14:50:06, yurys wrote:
> Invert the condition?

Done.

[pfeldman, 2014-11-07 14:52:43]

This does not fix the bug though.

[loislo, 2014-11-09 14:56:50]

On 2014/11/07 14:52:43, pfeldman wrote:
> This does not fix the bug though.

After an offline discussion we decided to change the worker name.
So the worker for an old version of devtools will coexist with worker for a new
version.
In this case these workers will do the job twice. As a result the developer will
loose the data
that has been saved into temp storage. This would affect save operation for
early recorded
cpu profiles, heap snapshots and timeline. Also timeline wouldn't be able to
show snapshots. 

We expecting that it would be very rare case.
As a workaround the developer could  record another profile or timeline.

[pfeldman, 2014-11-09 16:09:28]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2014-11-09 16:09:28]

lgtm.

[loislo, 2014-11-09 16:22:11]

The CQ bit was checked by loislo@chromium.org

[commit-bot: I haz the power, 2014-11-09 16:23:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/712593002/40001

[commit-bot: I haz the power, 2014-11-09 16:55:57]

Committed patchset #3 (id:40001) as 185012

[yurys, 2014-11-09 21:18:07]

On 2014/11/09 14:56:50, loislo wrote:
> On 2014/11/07 14:52:43, pfeldman wrote:
> > This does not fix the bug though.
> 
> After an offline discussion we decided to change the worker name.
> So the worker for an old version of devtools will coexist with worker for a
new
> version.
Why is it not being done as part of this change then? Without it the remote
profiling is still broken with or without this patch.

> In this case these workers will do the job twice. As a result the developer
will
> loose the data
> that has been saved into temp storage. This would affect save operation for
> early recorded
> cpu profiles, heap snapshots and timeline. Also timeline wouldn't be able to
> show snapshots. 
> 
Is there a plan to show a notification that the functionality is broken or we
just silently stop doing certain things?

> We expecting that it would be very rare case.
> As a workaround the developer could  record another profile or timeline.