Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 712573003: Remove usesCompositedScrolling (Closed)

Created:
6 years, 1 month ago by rafaelw
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : wee #

Total comments: 3

Patch Set 3 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -173 lines) Patch
M sky/engine/core/page/Page.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +0 lines, -25 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 3 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 2 4 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 2 5 chunks +1 line, -38 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 2 4 chunks +8 lines, -48 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
rafaelw
First crack at this. I'm guessing there's more to do. Please advise https://codereview.chromium.org/712573003/diff/20001/sky/engine/core/page/Page.h File sky/engine/core/page/Page.h ...
6 years, 1 month ago (2014-11-07 19:41:49 UTC) #2
abarth-chromium
LGTM https://codereview.chromium.org/712573003/diff/20001/sky/engine/core/rendering/RenderLayerScrollableArea.cpp File sky/engine/core/rendering/RenderLayerScrollableArea.cpp (right): https://codereview.chromium.org/712573003/diff/20001/sky/engine/core/rendering/RenderLayerScrollableArea.cpp#newcode309 sky/engine/core/rendering/RenderLayerScrollableArea.cpp:309: if (onlyScrolledCompositedLayers) On 2014/11/07 at 19:41:48, rafaelw wrote: ...
6 years, 1 month ago (2014-11-07 19:44:24 UTC) #3
abarth-chromium
On 2014/11/07 at 19:41:49, rafaelw wrote: > First crack at this. I'm guessing there's more ...
6 years, 1 month ago (2014-11-07 19:45:30 UTC) #4
rafaelw
pulled a bit more
6 years, 1 month ago (2014-11-07 21:42:35 UTC) #5
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-07 21:45:47 UTC) #6
rafaelw
6 years, 1 month ago (2014-11-07 21:59:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f3712c697e7bd3cf00cfa634b339961421c5755b.

Powered by Google App Engine
This is Rietveld 408576698