Source/core/rendering/RenderObject.cpp - Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase master Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderMultiColumnFlowThreadTest.cpp ('K') | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderPagedFlowThread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderObject.cpp

diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp

index db3a2524bf9aebbae145ec491b2f80fc7a4652ea..8af9ca28f8c0a61d160330e237729760301b3897 100644

--- a/Source/core/rendering/RenderObject.cpp

+++ b/Source/core/rendering/RenderObject.cpp

@@ -326,6 +326,13 @@ bool RenderObject::requiresAnonymousTableWrappers(const RenderObject* newChild)

return false;

}

+bool RenderObject::isValidColumnSpanAll() const

+ ASSERT(style()->columnSpan() == ColumnSpanAll);

+ RenderFlowThread* flowThread = flowThreadContainingBlock();

+ return flowThread && flowThread->isColumnSpanner(this);

void RenderObject::addChild(RenderObject* newChild, RenderObject* beforeChild)

{

ASSERT(isAllowedToModifyRenderTreeStructure(document()));