Source/core/rendering/RenderMultiColumnSpannerSet.cpp - Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnSpannerSet.cpp

Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase master Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderMultiColumnFlowThreadTest.cpp ('K') | « Source/core/rendering/RenderMultiColumnSpannerSet.h ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderMultiColumnSpannerSet.cpp

diff --git a/Source/core/rendering/RenderMultiColumnSpannerSet.cpp b/Source/core/rendering/RenderMultiColumnSpannerSet.cpp

index 69ae4f36398f84e73fb69e9fb029b7a511a12baf..7d60c1b6241276e2ee6f02aafc8daba1609a2336 100644

--- a/Source/core/rendering/RenderMultiColumnSpannerSet.cpp

+++ b/Source/core/rendering/RenderMultiColumnSpannerSet.cpp

@@ -28,6 +28,17 @@ bool RenderMultiColumnSpannerSet::recalculateColumnHeight(BalancedHeightCalculat

return false;

}

+void RenderMultiColumnSpannerSet::computeLogicalHeight(LayoutUnit, LayoutUnit logicalTop, LogicalExtentComputedValues& computedValues) const

+ computedValues.m_extent = m_rendererInFlowThread->logicalHeight();

+ computedValues.m_position = logicalTop;

+LayoutUnit RenderMultiColumnSpannerSet::pageLogicalHeight() const

+ return m_rendererInFlowThread->logicalHeight();

const char* RenderMultiColumnSpannerSet::renderName() const

{

return "RenderMultiColumnSpannerSet";