Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: Source/core/rendering/RenderMultiColumnSpannerSet.cpp

Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code review. Camelize. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderMultiColumnSpannerSet.h ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderMultiColumnSpannerSet.cpp
diff --git a/Source/core/rendering/RenderMultiColumnSpannerSet.cpp b/Source/core/rendering/RenderMultiColumnSpannerSet.cpp
index 69ae4f36398f84e73fb69e9fb029b7a511a12baf..d41b8b757de9777dcfb1be198c47b9f7c7fe6765 100644
--- a/Source/core/rendering/RenderMultiColumnSpannerSet.cpp
+++ b/Source/core/rendering/RenderMultiColumnSpannerSet.cpp
@@ -28,6 +28,18 @@ bool RenderMultiColumnSpannerSet::recalculateColumnHeight(BalancedHeightCalculat
return false;
}
+void RenderMultiColumnSpannerSet::computeLogicalHeight(LayoutUnit, LayoutUnit logicalTop, LogicalExtentComputedValues& computedValues) const
+{
+ computedValues.m_extent = m_rendererInFlowThread->logicalHeight();
+ computedValues.m_position = logicalTop;
+}
+
+LayoutUnit RenderMultiColumnSpannerSet::pageLogicalHeight() const
+{
+ ASSERT(!m_rendererInFlowThread->needsLayout());
+ return m_rendererInFlowThread->logicalHeight();
+}
+
const char* RenderMultiColumnSpannerSet::renderName() const
{
return "RenderMultiColumnSpannerSet";
« no previous file with comments | « Source/core/rendering/RenderMultiColumnSpannerSet.h ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698