Source/core/rendering/RenderMultiColumnSpannerSet.h - Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnSpannerSet.h

Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Let containingBlock() on a spanner return the multicol container. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderMultiColumnSet.cpp ('K') | « Source/core/rendering/RenderMultiColumnSet.cpp ('k') | Source/core/rendering/RenderMultiColumnSpannerSet.cpp » ('j') | Source/core/rendering/RenderObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderMultiColumnSpannerSet.h

diff --git a/Source/core/rendering/RenderMultiColumnSpannerSet.h b/Source/core/rendering/RenderMultiColumnSpannerSet.h

index 5b110f972e88e30ad7dd4f9965efcef0d6af21b4..9651f8a828704ceea2bfce59a193127cef8150d6 100644

--- a/Source/core/rendering/RenderMultiColumnSpannerSet.h

+++ b/Source/core/rendering/RenderMultiColumnSpannerSet.h

@@ -28,6 +28,8 @@ public:

protected:

virtual bool recalculateColumnHeight(BalancedHeightCalculation) override;

+ virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;

+ virtual LayoutUnit pageLogicalHeight() const override;

virtual const char* renderName() const override;

private: